Repository navigation
Read the fitted models' objective with xgb.config() - #34
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
eliotmcintire
added a commit
that referenced
this pull request
Oct 17, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every prediction run (hindcasts and NRV) stopped at the ignition step, because the fitted models' objective was read the old way and the current xgboost no longer stores it there. The objective is now read with xgboost's own function.
Affects: prediction runs with xgboost 3.x fitted models now run; results are unchanged.
Technical details
Defect:
fitObjective()(fireSense_ignitionPredict.R:275) readmodel$params$objective; a reloaded xgboost 3.x booster is a pointer object with no$params, so it stopped with "cannot read the objective". It now usesxgboost::xgb.config(model)$learner$objective$name, falling back toattr(model, "params")$objective, and keeps the error (message now names both).xgboost (>= 3.0.0)added toreqdPkgs. No other xgboost internals are read in this module or in fireSense_burn development.Tests: new
test-xgboost-objective.Rtrains real boosters, round-trips them throughsaveRDS/readRDS, and checks the objective and the mixed-objective error; it fails on development and passes here. The toy fold stand-ins now keep the objective inattr(, "params"), as real models do. Module tests viaconvertToPackage()+test_local(): development plus the new test 35 pass / 2 fail; this branch 37 pass / 0 fail.🤖 Generated with Claude Code
https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6