Repository navigation
fitFileSuffix: suffixed ledger files for test runs - #80
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
eliotmcintire
added
enhancement
eliotmcintire
added a commit
that referenced
this pull request
Oct 18, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test runs of the spread fit can now keep their results in their own file, so they no longer end up in the production fit file.
Affects: Nothing changes unless
fitFileSuffixis set; with it, the fit is written to the suffixed ledger file only.Depends-on: PredictiveEcology/fireSenseUtils#164
Technical details
Defect: the ledger file name was built with
spreadFitFilenameFor(fireYears), which had no suffix (R/ledgerWriteFile.R:18), so a test run could only avoid the production file by hand-buildingspreadFitFilename. New parameterfitFileSuffix(default""), the same in fireSense_spreadFit, fireSense_ignitionFit, fireSense_dataPrepFit and fireSense_ELFs and read withSpaDES.core::paramCheckOtherMods(), so the modules must agree (set it once with.globals = list(fitFileSuffix = "_boundfix_rep81")).ledgerWriteFile()passes it tospreadFitFilenameFor(fireYears, suffix); an explicitspreadFitFilenameis used as given. Tests: suffixed file name, a named file unchanged, and two modules disagreeing on the suffix are caught byparamCheckOtherMods(). Module suite viaconvertToPackage()+test_local()(scratch library with fireSenseUtils from PR 164 temporarily versioned 0.2.3.9104): 796 passed, 0 failed on this branch, 790 passed, 0 failed on development; the new tests fail on development. Floor raised to fireSenseUtils (>= 0.2.3.9104), the version PR 164 will have after merge. No version bump.🤖 Generated with Claude Code
https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6