Repository navigation
Parameter censoredRunaways: score a runaway replicate as at least the size it burned - #82
Closed
eliotmcintire wants to merge 1 commit into
Closed
eliotmcintire wants to merge 1 commit into
eliotmcintire wants to merge 1 commit into
Conversation
…t and the threshold calibration Default FALSE, passed to runDEoptim() and runSpreadWithoutDEoptim() as TRUE or NULL (censoredRunawaysOrNULL()), so a FALSE stays out of the fit's and the calibration's cache keys and existing fits are still found. With TRUE, fireSenseUtils::.objfunSpreadFit(censoredRunaways = TRUE): a simulated fire that reaches its buffer's edge ring keeps burning inside its buffer and is 'at least this big' in the size likelihood; the size terms score the size it burned, runawayBufferMultiple is not used. Why: the 2 x buffer rule made the fit prefer no year effect whatever the true one (known-sigma test, ELF 14.3, 2026-10-17). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
Collaborator
Author
|
Closing: Eliot chose penaliseRunaways = FALSE (simulated fires scored at the size they burned, buffer-bounded like observed fires). In the known-sigma tests on ELF 14.3 the censored variant gave the same fits as FALSE within Monte Carlo noise; a larger buffer is the remedy if buffer-filling fires become a problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends-on: PredictiveEcology/fireSenseUtils#166
A new switch for the spread fit: a simulated fire that reaches the edge of its buffer is scored as "at least as big as it burned" instead of as twice its buffer, which had made the fit prefer no year-to-year variation in fire spread. Off by default; nothing changes until a run turns it on.
Affects: with
censoredRunaways = TRUE, fits, their re-scores and the threshold calibration use the censored objective (new cache entries); with the default FALSE every cache key is unchanged.Technical details
defineParameter("censoredRunaways", "logical", default = FALSE);fitSpread()passescensoredRunawaysOrNULL(P(sim)$censoredRunaways)torunDEoptim()andestimateSNLLThresholdPostLargeFires()torunSpreadWithoutDEoptim()(both branches hand it to.objfunSpreadFit()), TRUE or NULL; NULL is added toomitArgsthroughfireSenseUtils::omitNullArgs()in bothCache()calls, asrunawayBufferMultiple = NAalready is, so a FALSE leaves the keys as they are.censoredRunawaysargument of fireSenseUtils (Spread objective: right-censor runaway replicates at the size they burned (censoredRunaways) fireSenseUtils#166); thereqdPkgsfloor follows once that merges and the version is bumped.test-objectiveSettings.R(TRUE reaches the fit, the calibration and the objective; FALSE arrives as NULL),test-metadata.Randtest-metadataContract.R(name, class, default). 142 module tests pass through the package rendition.yearSpreadSDwas at 0.03-0.11 with the 2 x buffer rule, 0.16-0.18 with censoring (and 0.16-0.19 withpenaliseRunaways = FALSE); with the year effect at its true value the optimum ofmaxAsymptotesits at the truth under censoring and 0.01-0.02 below it under the 2 x rule.🤖 Generated with Claude Code
https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6