Repository navigation
powerLaw link: gamma and p_c bounds calibrated per ELF; powerLaw and penaliseRunaways = FALSE are the defaults - #84
Merged
Conversation
…w and penaliseRunaways=FALSE are the defaults Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
eliotmcintire
added a commit
that referenced
this pull request
Oct 19, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spread fit now uses the "powerLaw" link by default and sets its shape number and the upper limit of its threshold from a quick simulation on each ELF's own landscape, so fits no longer waste time trying thresholds far above what that ELF can have. The simulated-size scoring of runaway fires is also switched off by default, because it shrank the year-to-year spread effect 3-4 times (Eliot, 2026-10-17).
Affects: the defaults of
spreadLink("powerLaw", was "ceiling") andpenaliseRunaways(FALSE, was TRUE) change, so new fits differ from earlier ones; "ceiling" and "climateOutside" still work with unchanged fits, cache keys and ledger rows.Depends-on: PredictiveEcology/fireSenseUtils#168
Technical details
powerLawGammawas a fixed 1.9 (fireSense_spreadFit.Rparameter) and p_c was bounded by the global 0.35 (R/fitSpread.RmaxAsymptoteBoundsOf()). WithspreadLink = "powerLaw",spreadFitPrep()now runsfireSenseUtils::calibratePowerLaw()once per ELF (R/powerLawCalibration.R) onflammableRTM(new input, latest vegetation year), with the fit's ownescapeSizeHa,jumpTries,jumpMeanDist, insideCache()keyed on the map, the arguments and the function bodies (notcores); the result issim$powerLawCalibration. The calibration always runs: p_c's bounds are floor + 0.01 to p_c50 +powerLawPcMargin(0.005).powerLawGamma = NA(default) uses the calibrated gamma and a number overrides gamma only. The ledger row also gets p_c50, the regression R2 and the margin. New parameterspowerLawPcMargin,powerLawFires(400),powerLawPGrid. FloorfireSenseUtils (>= 0.2.3.9108). Existing tests setspreadLink = "ceiling"andpenaliseRunaways = TRUEintoySim(); new tests cover the new defaults, calibration reaching the ledger row, DEoptim's p_c bounds coming from it, a numeric gamma still calibrating, and no calibration with the other links. Module suite (convertToPackage + test_local, fireSenseUtils 0.2.3.9108 from the PR branch): 904 passed, 0 failed; base 878 passed, 0 failed. README.md, generated from the Rmd, was not regenerated.🤖 Generated with Claude Code
https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6