Repository navigation
Predict with the intercept and centres of a ledger row - #25
Merged
Merged
Conversation
A row with an intercept and stored covariate centres is predicted with both; a row without them predicts as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
eliotmcintire
added a commit
that referenced
this pull request
Oct 5, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends-on: PredictiveEcology/fireSenseUtils#131
spreadProbOneELF()(fireSense_spreadPredict.R) split a row's parameters into covariate coefficients and logistic parameters by covariate name, so an(Intercept)coefficient would have been read as a logistic parameter, and it had no way to subtract the covariate centres a fit made with an intercept used. It now adds a column of 1s forfireSenseUtils::spreadInterceptTxtwhen the row has it, and subtracts the row's stored centres (covCentre_spread, read byledgerCovCentre(), one per ELF) from the rescaled covariates, as the fit did.The default is off: a row without an intercept or centres, such as every row written so far, predicts exactly as before (compared in the tests, and an older row beside one with centres in a two-ELF run). New
test-spreadIntercept.R(6 tests) fails on the base module and passes here; full module suite 54 tests, 0 failed (base 48, 0 failed), run against fireSenseUtils#131. No reqdPkgs floor yet: the fireSenseUtils version does not exist on development until #131 merges.🤖 Generated with Claude Code
https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv