ci: prevent tag-dispatch dry runs from publishing NuGet packages - #33
Merged
Merged
Conversation
AGiorgetti
marked this pull request as ready for review
October 5, 2026 10:27
AGiorgetti
commented
Oct 5, 2026
AGiorgetti
left a comment
Contributor
Author
There was a problem hiding this comment.
The changelog is wrong! the fix should be listed in a "## Fixes" section in a new "## Unreleased" section (top of the file) instead of updating an already existing release
Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A manual dispatch on a tag with
dry_run=truecould reach the production NuGet publish job even whenpublish=false. Require a push event for automatic tag publishing; retain explicit manual publishing on main/release//hotfix/ withpublish=true,dry_run=false, successful artifact prerequisites, and production approval.Fixes #19.
Changes
dotnetmocking and a fake key. Dry runs must schedule no publish job and record zero pushes.Validation
publish=false; non-dry-run tag dispatches already skipped pack despite the unsafe raw publish expression.NETSDK1064), 1 Native AOT prerequisite skip. Regenerating assets and rebuilding recovered both failures; affected tests plus release regressions then passed 175/175, zero skipped. All 808 executed cases have passing evidence across the full run and targeted recovery, not a single all-green full-suite invocation.Exact-head CI
CI run 37113397730 completed successfully for pull_request on
34d0549132b50bf0c0e09dd6e143ea1d26f7ea66.Limits
The local evaluator covers the current Actions expression subset and dependency graph, not live production approval behavior. Local Native AOT is inconclusive because the MSVC C++ linker toolchain is absent. No release workflow was dispatched, no real NuGet push ran, and no tags, security settings, or merges were changed. AgentStack CLI layout incompatibility required the repository-authorized GitHub CLI fallback.
Prepared with OpenAI Codex.