Skip to content

docs: cover the pip SDK route and runtime pitfalls for Windows HIP builds - #344

Open
Thatgfsj wants to merge 1 commit into
PrismML-Eng:prismfrom
Thatgfsj:docs/windows-hip-rocm-sdk
Open

Thatgfsj wants to merge 1 commit into
PrismML-Eng:prismfrom
Thatgfsj:docs/windows-hip-rocm-sdk

Conversation

@Thatgfsj

Copy link
Copy Markdown

What

Fills the Windows gaps in docs/build.md HIP section, from a from-source deployment on Windows 11 / RX 7800 XT (gfx1101) last week:

  1. pip / TheRock SDK route. AMD publishes no full ROCm installer for RDNA2/RDNA3 consumer cards on Windows, so the existing Windows bullet (x64 Native Tools Prompt + %HIP_PATH%\bin from an installer) is not reachable for exactly the cards most people want to use this backend on. The documented flow mirrors this fork's own windows-rocm release job step-by-step (rocm[libraries,devel] wheels, rocm-sdk init, rocm-sdk path --root/--cmake/--bin, the env vars, and the same cmake flags), including the MSVC-triple prerequisite.
  2. Windows runtime notes.
    • the HIP runtime dependency chain ggml-hip.dll needs resolvable next to the exe (amdhip64_7.dll -> rocm_kpack.dll + amd_comgr.dll; hipblas.dll -> rocsolver.dll; hipBLASLt per-ISA kernel data dirs), and where pip SDK keeps them;
    • an incomplete chain fails LoadLibrary silently - the backend never registers and inference quietly runs on CPU at 1-2 t/s, easily mistaken for a slow GPU; llama-server --list-devices is the discriminator;
    • fattn-mma template instances are multi-GB each: --parallel 24 on 64 GB RAM aborted with clang frontend command failed due to signal (compiler OOM, not a source error); 6-12 built clean.

Verification

Docs only; no code touched. Happy to adjust tone/placement - e.g. split the runtime notes into docs/backend/ if maintainers prefer.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Oct 10, 2026
…ilds

Signed-off-by: Thatgfsj <thatgfsj2324@gmail.com>
@Thatgfsj
Thatgfsj force-pushed the docs/windows-hip-rocm-sdk branch from 2596840 to d8737f1 Compare October 10, 2026 14:10
@bri-prism

Copy link
Copy Markdown
Collaborator

Thanks for writing this up. The runtime notes are really useful, especially the silent CPU fallback and the --list-devices check. A few things to fix before merging:

  1. The pip route isn't what this fork's releases use. windows-rocm in release.yml is inherited from upstream and doesn't run for our releases. Our Windows bundle (win-hip-radeon) is built by windows-hip in release-prism.yml, using the AMD HIP SDK installer (26.Q1). Could you describe the pip SDK as an alternative route rather than the supported or release one?
  2. The HIP SDK installer does cover these cards. Our release CI builds gfx1030-1032 and gfx1100-1102 with it, including your gfx1101. Please drop "AMD publishes no full ROCm installer for RDNA2/RDNA3 consumer cards on Windows", or limit it to cases where the installer isn't an option.
  3. "The Windows HIP release bundles ship them colocated" isn't accurate. Our bundle ships libhipblas.dll, libhipblaslt.dll, rocblas.dll and the rocblas/hipblaslt library folders, but not amdhip64_*, amd_comgr, rocm_kpack or rocsolver. The file names also differ between the installer and the pip SDK. Could you scope the DLL chain to pip-SDK builds?
  4. The commands are PowerShell, but the text says x64 Native Tools Command Prompt, which is cmd. Please point to Developer PowerShell for VS instead, or say to run powershell from that prompt.
  5. Please pin the wheel version, for example "rocm[libraries,devel]==7.14.0", so the steps stay reproducible.
  6. The out-of-memory note mentions rocWMMA flash attention, but the cmake example doesn't set -DGGML_HIP_ROCWMMA_FATTN=ON. Either add it, as both release jobs do, or reword the note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants