Feat/borrow - #159
Merged
Merged
Feat/borrow#159
Conversation
ChienNQuang
added
enhancement
Closed
vzart
reviewed
Jun 3, 2023
| return new PaginatedList<BorrowDto>(result, result.Count, pageNumber.Value, sizeNumber.Value); | ||
| } | ||
| } | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
Is this necessary to separate from getAll?
vzart
reviewed
Jun 3, 2023
vzart
left a comment
vzart
left a comment
Contributor
There was a problem hiding this comment.
Nothing seems wrong, wait for kaitoz11 review
kaitoz11
suggested changes
Jun 3, 2023
| return new PaginatedList<BorrowDto>(result, result.Count, pageNumber.Value, sizeNumber.Value); | ||
| } | ||
| } | ||
| } No newline at end of file |
kaitoz11
reviewed
Jun 3, 2023
| environment: | ||
| - ASPNETCORE_ENVIRONMENT=Testing | ||
| - PROFILE_DatabaseSettings__ConnectionString=Server=database;Port=5432;Database=mytestdb;User ID=profiletester;Password=supasupasecured; | ||
| - PROFILE_DatabaseSettings__ConnectionString=Server=database;Port=5432;Database=mytestdb;User ID=profiletester;Password=supasupasecured;Include Error Detail=true |
Member
Author
There was a problem hiding this comment.
the test error message should be clearer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.