ENH: Add pre-installation of torch to nightly health check - #102
Conversation
|
Warning Review limit reached
Next review available in: 26 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the Nightly Health GitHub Actions workflow to make the Windows GPU runner environment fail earlier and more deterministically when CUDA toolchain / PyTorch prerequisites for torch-scatter are missing or mis-resolved.
Changes:
- Adds an explicit
nvccavailability check to fail fast before dependency builds. - Pre-installs build prerequisites (
setuptools,wheel) and a CUDA-index PyTorch before resolving extras that may compile CUDA extensions. - Adds explicit
$LASTEXITCODEchecks after several install commands to avoid PowerShell masking failures.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.github/workflows/nightly-health.yml:70
- The nvcc check only searches PATH via Get-Command. On Windows runners, CUDA Toolkit often sets CUDA_PATH/CUDA_HOME without putting nvcc.exe on PATH, so this can fail the job even when nvcc is installed and would be found by build tooling. It also prints $nvcc.Source, which is not reliably the executable path for ApplicationInfo. Consider resolving an explicit nvcc path from PATH or CUDA_PATH/CUDA_HOME and invoking that path.
$nvcc = Get-Command nvcc -ErrorAction SilentlyContinue
if (-not $nvcc) {
Write-Error "nvcc not found on PATH; torch-scatter would build CPU-only"
exit 1
}
No description provided.