content: Launch post — Keep Docs Current as a Pull Request Evolves - #899
content: Launch post — Keep Docs Current as a Pull Request Evolves#899frances720 wants to merge 2 commits into
Conversation
Generated by launch-post skill.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Thanks Frances — reviewing this launch post for the new opt-in github_pr re-review-on-push mode as a documentation-specialist pass (correctness against source + doc quality/style). The verdict is Comment, not Approve: the post is accurate on all its load-bearing constraints and matches our blog conventions, but two things are worth a quick tweak before it ships.
Correctness against source — verified, all confirmed:
- New opt-in
trigger_on: [updated]re-reviews an open PR on every push — ✅ matches the Trigger modes docs and the August 2026 changelog. - Off/inert by default; existing triggers unaffected — ✅.
- Explicit
reposlist required,repos: alldisallowed for anupdatedclause — ✅ (and correctly scoped per match clause). - GitHub-only, no GitLab/Bitbucket equivalent — ✅.
- Draft PRs skipped, runs alongside the other modes — ✅.
- The YAML examples match the canonical config shape in
github-prs.mdx, and the/docs/for-docs/connect/triggers/github-prs#trigger-modeslink +#trigger-modesanchor both resolve — ✅.
Doc quality & style: Voice, structure (problem → what it does → who benefits → how to use), and frontmatter all fit the product-updates blog convention. Two findings below — one style-guide convention, one minor precision fix. Neither blocks; both are quick.
Nice, tightly-scoped post overall.
| import BlogNewsletterCTA from '@components/site/BlogNewsletterCTA.astro'; | ||
| import BlogRequestDemo from '@components/site/BlogRequestDemo.astro'; | ||
|
|
||
| A `github_pr` trigger now supports `trigger_on: [updated]`, which re-runs Promptless on an open pull request each time new commits are pushed. The documentation suggestion stays current as the code changes, not just at the moment the PR opens. |
There was a problem hiding this comment.
Style-guide convention: in prose we refer to these as a "GitHub PR trigger," not the bare code identifier github_pr (Manny, PR #781 review — reserve github_pr for places where a literal config/YAML value is genuinely required). The trigger_type: github_pr inside the YAML blocks below is correct and should stay; it's just this opening prose sentence. Suggested rewording: "A GitHub PR trigger now supports a new trigger_on value, updated, which re-runs Promptless…" — that keeps updated as the literal config value while dropping the bare identifier from prose.
| - **An explicit `repos` list is required.** The `updated` mode can't use `repos: all`. A push-on-every-PR to every repo would generate disproportionate volume, so the mode requires naming repos explicitly. | ||
| - **Draft PRs are skipped**, same as the other modes. | ||
| - **Only GitHub is supported.** GitLab and Bitbucket don't have an equivalent. | ||
| - **Each push produces a full re-review pass.** A PR with 20 incremental commits yields 20 passes. Scope it with `trigger_directories` if you want to limit which pushes actually trigger a run. |
There was a problem hiding this comment.
Minor precision: a re-review pass fires per push, not per commit. The source docs phrase it as "Every push produces a re-review pass, so a PR with many incremental commits yields many passes" — several commits pushed together count as one pass, so "20 incremental commits yields 20 passes" only holds if each commit is pushed separately. Suggest matching the docs' framing, e.g. "Each push produces a full re-review pass, so a PR pushed to many times yields many passes."
- Use 'GitHub PR trigger' in prose instead of bare github_pr identifier - Correct 'commits yields passes' to 'pushes yields passes': several commits pushed together count as one re-review pass, not one per commit Addresses bot review comments on PR #899.
Feature
A new opt-in
trigger_on: [updated]mode re-reviews an open GitHub PR on every push. Documentation suggestions stay current as code changes during review, not just at open, approval, or merge.Entries considered this run
Window: 2026-08-17 → 2026-08-24 (7 days). 6 commits, 5 changelog entries considered, 3 qualified (this is one of three PRs from this run — see also #897 for MCP triggers and #898 for Jira triggers).
trigger_on: [updated]value turns Promptless into a review bot that re-reviews an open PR on every push6 commits in window. 5 entries considered, 3 qualified.
Covered entry (full text)
Source: commit ffb47b1 (2026-08-19).
PR(s) researched
updatedtrigger (review on push)File
src/content/blog/product-updates/github-pr-review-on-push.mdxAI-generated draft — needs human review before publishing.
Generated by Claude Code