refactor(web): name the changelog regex groups and explain the OG suppression by PunGrumpy · Pull Request #187 · PunGrumpy/docker-doctor

PunGrumpy · 2026-10-23T02:07:59Z

Description

Two lint suppressions in the website did not follow the repository's rule (fix the code, and when a suppression is right, say why inline).

parseChangelog uses named capture groups. It read shaMatch[1] and shaMatch[2] under oxlint-disable prefer-named-capture-group. CHANGE_LINE_RE names the sha and title groups and moves out of the loop. Parsing packages/docker-doctor/CHANGELOG.md with the old and the new parser gives identical JSON (21 versions).
The OG image suppression gives its reason. next/no-img-element is wrong in app/og/docs/[...slug]/route.tsx: ImageResponse renders through Satori, which cannot load next/image. The directive now says so.

Related Issues

N/A. Found by a comment audit of the repository.

Checklist

I've reviewed my code
I've written tests
I've generated a changeset file, if this changes a published package
I've updated the docs, if necessary

Screenshots (if applicable)

N/A. /changelog renders the same entries.

Additional Notes

The web app has no unit tests. The parser change was checked by comparing both parsers' output on the real changelog, and the website builds.
ultracite check and typecheck are clean. No changeset: nothing here ships in @docker-doctor/cli.

vercel · 2026-10-23T02:08:02Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docker-doctor	Ready	Preview	Oct 23, 2026 2:37am UTC

changeset-bot · 2026-10-23T02:08:08Z

⚠️ No Changeset found

Latest commit: dde16fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-10-23T02:08:11Z

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: b66fe00e-5c5f-430d-b491-19eb42cdba68

📥 Commits

Reviewing files that changed from the base of the PR and between 2ca1312 and dde16fe.

📒 Files selected for processing: 2

apps/web/app/og/docs/[...slug]/route.tsx
apps/web/lib/changelog.ts

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-23T02:08:15Z

The latest Docker Doctor scan for this pull request. Learn more about Docker Doctor.

File	Status	Issues	Updated
`Dockerfile`	Error	1 error, 2 info	Oct 23, 2026 2:36am UTC

Score: 84 / 100 · Good

3 issues

Dockerfile

Dockerfile:2 Potential secret found in ENV: 'DB_PASSWORD'. no-secrets-in-env
Dockerfile:1 No HEALTHCHECK instruction found. require-healthcheck
Dockerfile:1 No LABEL metadata was found in this Dockerfile. require-labels

_{Scanned by Docker Doctor for commit dde16fe.}

github-actions · 2026-10-23T02:08:19Z

React Doctor found no new issues. 🎉

_{Reviewed by React Doctor for commit dde16fe.}

pkg-pr-new · 2026-10-23T02:08:48Z

Open in StackBlitz

npm i https://pkg.pr.new/@docker-doctor/cli@187

commit: dde16fe

parseChangelog matched each change line with unnamed groups under an `oxlint-disable prefer-named-capture-group`. CHANGE_LINE_RE names the `sha` and `title` groups and moves out of the loop. Parsing packages/docker-doctor/CHANGELOG.md gives the same 21 versions as before.

The docs OG route turns off next/no-img-element for its background image without saying why. ImageResponse renders through Satori, which cannot load next/image, so the reason is now written inline.

PunGrumpy added the pkg: web Web application in apps/web label Oct 23, 2026

vercel Bot deployed to Preview October 23, 2026 02:08

View deployment

PunGrumpy added 2 commits October 23, 2026 09:35

refactor(web): give the OG image suppression a reason

dde16fe

The docs OG route turns off next/no-img-element for its background image without saying why. ImageResponse renders through Satori, which cannot load next/image, so the reason is now written inline.

PunGrumpy force-pushed the refactor/web-workarounds branch from 06dbd09 to dde16fe Compare October 23, 2026 02:35

vercel Bot deployed to Preview October 23, 2026 02:37

View deployment

PunGrumpy merged commit d6acee8 into main Oct 23, 2026
20 of 21 checks passed

PunGrumpy deleted the refactor/web-workarounds branch October 23, 2026 02:38

Navigation Menu

Repository navigation

refactor(web): name the changelog regex groups and explain the OG suppression - #187

refactor(web): name the changelog regex groups and explain the OG suppression#187
PunGrumpy merged 2 commits into
mainfrom
refactor/web-workarounds

PunGrumpy commented Oct 23, 2026

Uh oh!

vercel Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading

Review limit reached

Uh oh!

github-actions Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

PunGrumpy commented Oct 23, 2026

Description

Related Issues

Checklist

Screenshots (if applicable)

Additional Notes

Uh oh!

vercel Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

github-actions Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Oct 23, 2026 •

edited

Loading

changeset-bot Bot commented Oct 23, 2026 •

edited

Loading

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading

github-actions Bot commented Oct 23, 2026 •

edited

Loading

github-actions Bot commented Oct 23, 2026 •

edited

Loading

pkg-pr-new Bot commented Oct 23, 2026 •

edited

Loading