refactor(core): replace three comment-backed workarounds

packages/core/src/config/loader.ts

@@ -20,6 +20,30 @@ const fileExists = async (filePath: string): Promise<boolean> => {
   }
 };
 
+const CONFIG_FILE_NAMES = [
+  "docker-doctor.config.ts",
+  "docker-doctor.config.js",
+  "docker-doctor.config.mjs",
+  "docker-doctor.config.cjs",
+  "docker-doctor.config.json",
+  "docker-doctor.config.yaml",
+  "docker-doctor.config.yml",
+];
+
+const findFirstConfigFile = async (
+  rootDir: string
+): Promise<string | undefined> => {
+  const candidates = CONFIG_FILE_NAMES.map((name) => path.join(rootDir, name));
+
+  const exists = await Promise.all(
+    candidates.map(async (candidate) => await fileExists(candidate))
+  );
+
+  const first = exists.indexOf(true);
+
+  return first === -1 ? undefined : candidates[first];
+};
+
 const describeError = (cause: unknown): string =>
   cause instanceof Error ? cause.message : String(cause);
 
@@ -194,26 +218,11 @@ export const loadConfig = async (
 
     configObject = await importConfig(fullPath);
   } else {
-    const candidates = [
-      "docker-doctor.config.ts",
-      "docker-doctor.config.js",
-      "docker-doctor.config.mjs",
-      "docker-doctor.config.cjs",
-      "docker-doctor.config.json",
-      "docker-doctor.config.yaml",
-      "docker-doctor.config.yml",
-    ];
-
-    /* eslint-disable no-await-in-loop */
-    for (const cand of candidates) {
-      const fullPath = path.join(rootDir, cand);
-
-      if (await fileExists(fullPath)) {
-        configObject = await importConfig(fullPath);
-        break;
-      }
+    const configPath = await findFirstConfigFile(rootDir);
+
+    if (configPath !== undefined) {
+      configObject = await importConfig(configPath);
     }
-    /* eslint-enable no-await-in-loop */
 
     configObject ??= await readPackageConfig(rootDir);
   }

packages/core/src/rules/compose-mounts.ts

@@ -3,7 +3,6 @@ import path from "node:path";
 import {
   composeField,
   isComposeMapping,
-  isComposeSequence,
   isComposeString,
 } from "../parsers/compose-value";
 import { hasText } from "../text";
@@ -121,8 +120,7 @@ export const volumeMount = (
     };
   }
 
-  // A sequence here is invalid Compose. It has none of these keys.
-  if (isComposeMapping(volume) || isComposeSequence(volume)) {
+  if (isComposeMapping(volume)) {
     return {
       readOnly: isComposeTrue(composeField(volume, "read_only")),
       source: stringOrUndefined(composeField(volume, "source")),
@@ -251,7 +249,7 @@ export const classifyHostPath = (hostPath: string): HostPathScope => {
     return normalized.startsWith("~/.") ? "home-dotfile" : "host";
   }
 
-  if (normalized === "." || normalized.startsWith("./")) {
+  if (normalized === ".") {
     return "project";
   }
 

packages/core/test/compose-mounts.test.ts

@@ -0,0 +1,20 @@
+import { describe, expect, test } from "bun:test";
+
+import type { HostPathScope } from "../src/rules/compose-mounts";
+import { classifyHostPath } from "../src/rules/compose-mounts";
+
+describe("classifyHostPath", () => {
+  const cases: [string, HostPathScope][] = [
+    [".", "project"],
+    ["./", "project"],
+    [".//", "project"],
+    ["./src", "project"],
+    ["src/data", "project"],
+    ["./../shared", "parent"],
+    ["../shared", "parent"],
+  ];
+
+  test.each(cases)("%s is %s", (hostPath, scope) => {
+    expect(classifyHostPath(hostPath)).toBe(scope);
+  });
+});

packages/core/test/config.test.ts

@@ -22,6 +22,24 @@ describe("loadConfig", () => {
     expect(config).toEqual({});
   });
 
+  test("reads the first config file in lookup order", async () => {
+    await fs.writeFile(
+      path.join(dir, "docker-doctor.config.yaml"),
+      "rules:\n  docker-doctor/no-root-user: info\n"
+    );
+    await fs.writeFile(
+      path.join(dir, "docker-doctor.config.json"),
+      JSON.stringify({ rules: { "docker-doctor/no-root-user": "error" } })
+    );
+    await fs.writeFile(
+      path.join(dir, "docker-doctor.config.mjs"),
+      'export default { rules: { "docker-doctor/no-root-user": "warning" } };\n'
+    );
+
+    const config = await loadConfig(dir);
+    expect(config.rules).toEqual({ "docker-doctor/no-root-user": "warning" });
+  });
+
   test("warns about unknown rule and category keys", async () => {
     await fs.writeFile(
       path.join(dir, "docker-doctor.config.json"),

packages/core/test/rules.test.ts

@@ -1227,6 +1227,28 @@ describe("Compose Security Rules", () => {
     );
   });
 
+  test("compose mount rules skip a volume entry written as a sequence", () => {
+    const source = `services:
+  agent:
+    image: myagent:1.0
+    volumes:
+      - [/var/run/docker.sock, /var/run/docker.sock]
+      - [/, /host]
+`;
+
+    const composeContent = parseCompose(source, "compose.yml");
+
+    expect(
+      noDockerSocketMount.check(composeContent, "compose.yml")
+    ).toHaveLength(0);
+    expect(noBroadBindMount.check(composeContent, "compose.yml")).toHaveLength(
+      0
+    );
+    expect(
+      preferReadOnlyBindMount.check(composeContent, "compose.yml")
+    ).toHaveLength(0);
+  });
+
   test("prefer-read-only-bind-mount: writable host paths in short and long syntax", () => {
     const source = `services:
   web: