Repository navigation
ci(changesets): skip the check when a package.json bump only touches devDependencies - #62
Conversation
…devDependencies Dependabot's development group bumps devDependencies in packages/vecstore-sdk/package.json, and Verify Changesets failed on it (#53) even though nothing published changes. A changed package.json now counts only when it differs from the base outside devDependencies. Source changes and every other package.json field still need a changeset. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly identifies the CI changeset check and the specific exception for package.json changes that only update devDependencies. |
| Description check | |
The description explains the background, implementation, exclusions, and verification results. It does not use the template's Background, Summary, or Checklist headings, and it does not explicitly com… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Description check
-
Explanation
The description explains the background, implementation, exclusions, and verification results. It does not use the template's Background, Summary, or Checklist headings, and it does not explicitly complete the checklist, but it provides the required technical context and verification details.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the manifest lines
And skips the unchanged package signs
Source edits still count their say
A changeset marks the change today
Then hops along its merry way(final)
Comment @coderabbitai help to get the list of available commands.
commit: |
|
Security review: nothing to raise. Read the updated workflow step, its Reviewed at |
Verify Changesets failed on #53, a Dependabot bump of the
developmentgroup, because any change topackages/*/package.jsonrequired a changeset. That bump only toucheddevDependencies, so nothing published changed. Each future development-group bump would fail the same way and need theskip-changesetlabel by hand.Change
A changed
packages/*/package.jsonnow counts only when it differs from the base afterjq -S 'del(.devDependencies)'on both sides. Changes underpackages/*/src/**, and every otherpackage.jsonfield (version,dependencies,peerDependencies,exports, and so on), still need a changeset. Apackage.jsonthat is added or deleted still counts.Considered and dropped
skip-changesetthroughdependabot.yml. Labels there apply to the wholebunentry, so production bumps would skip the check too, and those do ship.scriptsas well. Lifecycle scripts can reach consumers, so onlydevDependenciesis exempt.Verification
I ran the step's
runscript withbash -e, the shell Actions uses, against seven commits. Before this change, the two dev-only cases failed. After it, every case matches.9a8c5c1)devDependenciesbumppeerDependencieschangeversionchangedevDependenciesbump plus a newdependenciesentrysrcchange without a changesetsrcchange with a changesetactionlintpasses on the workflow. This PR does not touchpackages/or.changeset/, so Verify Changesets does not run on it.🤖 Generated with Claude Code
Summary by CodeRabbit