Skip to content

refactor(web): drop the geist base layer that the next one overrides - #66

Merged
PunGrumpy merged 1 commit into
mainfrom
refactor/web-geist-base-layer
Oct 23, 2026
Merged

PunGrumpy merged 1 commit into
mainfrom
refactor/web-geist-base-layer

Conversation

@PunGrumpy

Copy link
Copy Markdown
Owner

Background

apps/web/app/styles/geist.css had two @layer base blocks in a row, the second labelled /* This layer is by PunGrumpy */. The repository keeps no comments in code, and the label existed only because there were two blocks. The first block was dead. Its * rule is repeated word for word in the second block, and its body background (bg-background-100) is overridden by the second block's bg-background-200.

Summary

  • Deletes the first base block and the label: 11 lines, nothing added. One base layer is left, and it needs no label. Authorship stays in git blame, and the Apache-2.0 notice for the ported Geist tokens stays in apps/web/THIRD_PARTY_NOTICES.md.
  • Leaves apps/web/app/globals.css alone. Its body rule looks like a duplicate of Geist's, but it is load-bearing: in a test build without it, the compiled CSS put Fumadocs' body{background-color:var(--color-fd-background)…} after the Geist rule, which changes the page background.

Verification

  • I built the site before and after the change, split the largest compiled stylesheet one rule per line, and diffed the two. The only difference is one removed copy of @supports (color:color-mix(in lab, red, red)){*{outline-color:color-mix(in oklab, var(--ds-gray-600) 50%, transparent)}}, a rule the remaining block still emits. Nothing was added, and the body rules compile to the same text.
  • bun run build and bun run typecheck in apps/web pass, and bun run check passes.

Checklist

  • Tests have been added or updated (no behavior change; the compiled stylesheet comparison is the check)
  • Documentation has been added or updated (nothing user-facing changes)
  • A changeset has been added for vecstore-sdk (site only)
  • I have reviewed this pull request myself

@PunGrumpy PunGrumpy added the refactor Changes structure or removes dead code without changing behavior label Oct 22, 2026
@vercel

vercel Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
vecstore-sdk Ready Ready Preview Oct 23, 2026 2:24am UTC

@changeset-bot

changeset-bot Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d144477

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 170835b9-3079-49ed-9c1b-75de55367c1d
📥 Commits

Reviewing files that changed from the base of the PR and between 28ad8e2 and d144477.

📒 Files selected for processing: 1
  • apps/web/app/styles/geist.css
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/vecstore-sdk@66

commit: d144477

geist.css had two base layers in a row. The first block's * rule was
repeated word for word in the second, and its body background
(bg-background-100) was overridden by the second block's
bg-background-200. The comment above the second block was there only
to tell the two apart, and the repo keeps no comments in code.

I built the site before and after and split the largest compiled
stylesheet to one rule per line. The only difference is one removed
copy of the duplicated outline-color rule; nothing was added and the
body rules compile to the same text.
@PunGrumpy
PunGrumpy force-pushed the refactor/web-geist-base-layer branch from 33e0dcf to d144477 Compare October 23, 2026 02:23
@PunGrumpy
PunGrumpy merged commit 54821b7 into main Oct 23, 2026
12 of 13 checks passed

This branch was successfully deployed

1 active deployment
Preview — d1444776 Deployed Oct 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Changes structure or removes dead code without changing behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant