Repository navigation
refactor(web): drop the geist base layer that the next one overrides - #66
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 58 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
geist.css had two base layers in a row. The first block's * rule was repeated word for word in the second, and its body background (bg-background-100) was overridden by the second block's bg-background-200. The comment above the second block was there only to tell the two apart, and the repo keeps no comments in code. I built the site before and after and split the largest compiled stylesheet to one rule per line. The only difference is one removed copy of the duplicated outline-color rule; nothing was added and the body rules compile to the same text.
33e0dcf to
d144477
Compare
Background
apps/web/app/styles/geist.csshad two@layer baseblocks in a row, the second labelled/* This layer is by PunGrumpy */. The repository keeps no comments in code, and the label existed only because there were two blocks. The first block was dead. Its*rule is repeated word for word in the second block, and itsbodybackground (bg-background-100) is overridden by the second block'sbg-background-200.Summary
git blame, and the Apache-2.0 notice for the ported Geist tokens stays inapps/web/THIRD_PARTY_NOTICES.md.apps/web/app/globals.cssalone. Itsbodyrule looks like a duplicate of Geist's, but it is load-bearing: in a test build without it, the compiled CSS put Fumadocs'body{background-color:var(--color-fd-background)…}after the Geist rule, which changes the page background.Verification
@supports (color:color-mix(in lab, red, red)){*{outline-color:color-mix(in oklab, var(--ds-gray-600) 50%, transparent)}}, a rule the remaining block still emits. Nothing was added, and thebodyrules compile to the same text.bun run buildandbun run typecheckinapps/webpass, andbun run checkpasses.Checklist
vecstore-sdk(site only)