Split-TU: extract ScriptGlobalAssignAndLvalueResolve from JIT.php (#36387) - #36789
Merged
Merged
Conversation
2 tasks
Owner
Author
PurHur
force-pushed
the
agent/issue-36387-script-global-assign-lvalue
branch
from
September 5, 2026 04:59
f151e55 to
d59176e
Compare
…6387) Move promoteNativeLongLvalueToValueBox→resolveScriptGlobalAssignTarget into a Concern trait so the JIT hub keeps shrinking toward gen-0 split-TU iterability. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
agent/issue-36387-script-global-assign-lvalue
branch
from
September 5, 2026 05:06
d59176e to
9bec07d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScriptGlobalAssignAndLvalueResolve(~663 lines:promoteNativeLongLvalueToValueBox→resolveScriptGlobalAssignTarget) fromlib/JIT.phpinto a Concern trait for gen-0 split-TU / size-budget ratchet (Performance: compile-time targets and gate — hello-world ≤ 3 s warm, MiniWebApp ≤ 10 s, 400 statements per function in < 5 s, one-file edit rebuild < 25 % of full, spine gen-0 < 30 min with split-TU (script/bench-gate.php --compile, bin/compile.php, lib/Compiler.php) (re-#36224 slice 2, re-#36199) #36387).Zend/zend_execute_API.c/Zend/zend_execute.cassign + script-global paths; no new C ABI / IR shape change.Part of #36387. Lane overflow from closed #36143–#36148 (
#36387 % 3 == 0is lane A).Test plan
./script/phpunit.sh --filter 'SpineChunkRuntimeMethodDemoteTest|BootstrapSelfhostBundleTest'→ 7/7./script/aot-smoke.sh→ 9/9 + size gate OKmake north-star5-verify-fast→ OK (spine 8219/8219)./script/check-size-budgets.sh→ OK (lib/JIT.phpbudget 11042)