Split-TU: extract LocalReleaseUnsetAndVarFetchDest from JIT.php (#36387) - #36791
Closed
PurHur wants to merge 2 commits into
Closed
Split-TU: extract LocalReleaseUnsetAndVarFetchDest from JIT.php (#36387)#36791PurHur wants to merge 2 commits into
PurHur wants to merge 2 commits into
Conversation
Move local-release / unset nulling and VAR_FETCH dest-use analysis (~1036 lines) into a Concern trait so JIT.php ratchets toward split-TU iterability under the size-budget gate (Part of #36387). Co-authored-by: Cursor <cursoragent@cursor.com>
…#36387) Refresh inventory profile, status snapshot, sidecar stamp, and BootstrapSelfhostBundleTest expect after adding the Concern to the spine (on top of ByRefFormalAssignAndCallArgAdapt). Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
Owner
Author
|
Superseded by maintainer rebase onto current master (ResolveJitOutgoingCall tip) — closing in favor of the up-to-date PR. Same Concern extract. |
4 tasks
Owner
Author
|
Closed as superseded by merged #36792 (same LocalReleaseUnsetAndVarFetchDest extract, rebased onto ResolveJitOutgoingCall master tip). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
releaseJitFunctionLocalsAtReturn…varFetchDestUsedAsIncDec(~1036 lines) fromlib/JIT.phpintolib/JIT/Concern/LocalReleaseUnsetAndVarFetchDest.php(Part of Performance: compile-time targets and gate — hello-world ≤ 3 s warm, MiniWebApp ≤ 10 s, 400 statements per function in < 5 s, one-file edit rebuild < 25 % of full, spine gen-0 < 30 min with split-TU (script/bench-gate.php --compile, bin/compile.php, lib/Compiler.php) (re-#36224 slice 2, re-#36199) #36387).lib/JIT.php→ 12302), and sync inventory/status to 8217/8217.ZEND_UNSET_*/ZEND_FETCH_*destination classification inZend/zend_execute.c/Zend/zend_vm_def.h.Closes nothing alone (Part of #36387).
Test plan
./script/docker-exec.sh -- bash -lc 'php -l lib/JIT.php && php -l lib/JIT/Concern/LocalReleaseUnsetAndVarFetchDest.php && ./script/check-size-budgets.sh && php script/check-selfhost-spine-count-sync.php && php script/check-selfhost-spine-sidecar-sync.php && php script/check-selfhost-spine-coverage-sync.php'./script/phpunit.sh --filter 'SpineChunkRuntimeMethodDemoteTest|BootstrapSelfhostBundleTest'→ OK (7 tests, 645 assertions)make north-star5-verify-fast→ OK (spine 8217/8217; VM driver probe OK)./script/aot-smoke.sh→ 9 passed, 0 failedMade with Cursor