Split-TU: extract LocalReleaseUnsetAndVarFetchDest from JIT.php (#36387) - #36793
Closed
PurHur wants to merge 2 commits into
Closed
Split-TU: extract LocalReleaseUnsetAndVarFetchDest from JIT.php (#36387)#36793PurHur wants to merge 2 commits into
PurHur wants to merge 2 commits into
Conversation
Move local-release / unset nulling and VAR_FETCH dest-use analysis (~1036 lines) into a Concern trait so JIT.php ratchets toward split-TU iterability under the size-budget gate (Part of #36387). Co-authored-by: Cursor <cursoragent@cursor.com>
…#36387) Refresh inventory/docs/sidecar stamp and size-budget ratchet after rebase onto ResolveJitOutgoingCall / ByRefFormal peers. Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
releaseJitFunctionLocalsAtReturn→varFetchDestUsedAsIncDec) fromlib/JIT.phpintolib/JIT/Concern/LocalReleaseUnsetAndVarFetchDest.php(Part of Performance: compile-time targets and gate — hello-world ≤ 3 s warm, MiniWebApp ≤ 10 s, 400 statements per function in < 5 s, one-file edit rebuild < 25 % of full, spine gen-0 < 30 min with split-TU (script/bench-gate.php --compile, bin/compile.php, lib/Compiler.php) (re-#36224 slice 2, re-#36199) #36387).lib/JIT.php→ 11704 lines (under 20k); spine 8218/8218; SPINE_CHUNK demote + size-budget sync.php-src reference: end-of-scope CV release / unset in
Zend/zend_execute.candZend/zend_vm_def.h(ZEND_UNSET_CV) — move-only Concern extract; no new C ABI and no opcode/IR shape change.Test plan
php -lonlib/JIT.php+ Concern./script/phpunit.sh --filter SpineChunkRuntimeMethodDemoteTestmake north-star5-verify-fast./script/aot-smoke.sh→ 9/9./script/check-generated-docs.shPart of #36387.
Made with Cursor