Expose hardware devices to filter graphs - #2404
Open
happyme531 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Hardware filters such as hwupload require AVFilterContext.hw_device_ctx, but PyAV currently has no public way to provide one. This implements the device-context part of the hardware-filter plumbing discussed in #2218. AVHWFramesContext plumbing for hardware-decoded buffer sources remains separate work.
Lifetime handling
HWDevice owns the reference returned by av_hwdevice_ctx_create. Each compatible filter receives its own av_buffer_ref before avfilter_init_dict, and normal filter-context destruction releases that reference. The graph also retains the Python HWDevice object.
Validation