Repository navigation
Conversation
…eters A master built before the 2011-05-12 revision of its command set answers "Unknown parameter" to the channel commands as this driver sends them. DeviceConfiguration says from the master's build date whether it takes the extended parameters, and the commands leave them out when it does not: `ti` in C0 DI and C0 TR, `td` in C0 TP, `po`, `gi gj gk`, `lk ik` and `se sz` in C0 AS, `po` and `gi gj gk` in C0 DS. A master built later, or one with no build date, is sent exactly what it was before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BioCam
changed the title
BioCam
changed the title
STAR pipettes: old master is sent limited PIP parameters
Contributor
Collaborator
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On main the channel commands always carry
ti,td,po, the TADM fields and the second-section aspiration fields. A master built before the 2011-05-12 revision of its command set does not know them and answerser01/31"Unknown parameter":C0 DIfails whenever setup has to initialize the channels, andC0 ASon every aspirate (#1050, master8.0S 2011-03-02). The master's version number does not follow its releases - that8.0Sis from 2011, a7.6Sfrom 2021 - so its build date is what decides.DeviceConfiguration.takes_extended_pip_parameters: true fromEXTENDED_PIP_PARAMETERS_SINCEon, and when no build date was readtiinC0 DIandC0 TR,tdinC0 TP,po,gi gj gk,lk ikandse szinC0 AS,poandgi gj gkinC0 DS- the set Add Legacy Starlet Support #1002 leaves out on the legacy backend, which is what Hamilton STAR firmware error: C0DI / C0AS “Unknown parameter” with older firmware #1050 was resolved withTests: pipettes_tests - a master one day older than the threshold is sent
DI,TPandTRwithoutti/td, andAS/DSwithout the parameters above.🤖 Generated with Claude Code