Rust API for pyinitconfig - #6173
Conversation
2f0308c to
f15f4fc
Compare
|
According to codecov almost none of the API surface is tested. Can you please make sure there's coverage for all the |
57b35c8 to
f622003
Compare
Merging this PR will degrade performance by 0.43%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | into_u128_small |
876.1 ns | 1,041.4 ns | -15.87% |
| ❌ | into_u128_zero |
816 ns | 925.7 ns | -11.85% |
| ⚡ | into_biguint_small |
1.5 µs | 1.3 µs | +16.79% |
| ⚡ | into_biguint_zero |
1.4 µs | 1.2 µs | +13.49% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing Person-93:pyinitconfig (5a5770e) with main (6a930e9)
Footnotes
-
6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
@codspeedbot fix this regression |
|
Maintainers (@ngoldbaum), is test coverage OK. Do we need a test case which deliberately causes initialization to fail so the error handling code is covered? |
c8f66ec to
99b41b0
Compare
141a505 to
7931138
Compare
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, some various thoughts and suggestions. Sorry it took a long time to get around to this one.
5ca5f0a to
5c01d67
Compare
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, this looks good to me!
2adc377 to
301eaa1
Compare
|
I'm ignoring the |
Co-authored-by: David Hewitt <mail@davidhewitt.dev>
Use OnceCell instead of Once
|
@ngoldbaum what happened to CI for this PR? I see that you cancelled them after they were stuck for a few hours, so what happens now? |
|
Maybe try debugging locally or in your fork? I canceled CI because it was blocking CI on other PRs. |
|
@ngoldbaum , I tried running CI again to see if it was a transient issue or if I could get logs, and I've confirmed that the pytest |
|
I usually enable actions in my fork of a project when I’m limited by permissions like you’re hitting here. |
af0753d to
5a5770e
Compare
Adds a rust API to initialize the embedded interpreter with configuration.
Closes #6153