Skip to content

internal: No std broken on main - #6383

Merged
davidhewitt merged 8 commits into
PyO3:mainfrom
Person-93:no_std_broken_on_main
Sep 12, 2026
Merged

davidhewitt merged 8 commits into
PyO3:mainfrom
Person-93:no_std_broken_on_main

Conversation

@Person-93

@Person-93 Person-93 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

The main branch currently has failing no_std jobs. See #6376

@codspeed-hq

codspeed-hq Bot commented Sep 2, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 11.56%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 2 regressed benchmarks
✅ 139 untouched benchmarks
⏩ 6 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
into_biguint_zero 1.2 µs 1.4 µs -11.89%
critical_section_creation 1.3 µs 1.5 µs -11.24%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing Person-93:no_std_broken_on_main (21f0932) with main (ee629fb)

Open in CodSpeed

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Person-93
Person-93 force-pushed the no_std_broken_on_main branch from dd99a97 to 26feb66 Compare September 2, 2026 22:14
@Person-93
Person-93 force-pushed the no_std_broken_on_main branch from cd3d4cc to 1cdc1f6 Compare September 4, 2026 01:31
@Person-93

Copy link
Copy Markdown
Contributor Author

@davidhewitt , I am not sure why zope installation is failing or why that's on no_std, but can you merge this PR anyway and have that be a separate PR? This one has other fixes.

@davidhewitt

Copy link
Copy Markdown
Member

The zope install is non-blocking, the real failure is

pytests/.nox/test/lib/python3.14/site-packages/pyo3_pytests/pyo3_pytests.cpython-314-x86_64-linux-gnu.so' has no attribute 'path' (most likely due to a circular import)

Which looks likely to be related to gating that module on std?

@Person-93

Person-93 commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

The zope install is non-blocking, the real failure is

pytests/.nox/test/lib/python3.14/site-packages/pyo3_pytests/pyo3_pytests.cpython-314-x86_64-linux-gnu.so' has no attribute 'path' (most likely due to a circular import)

Which looks likely to be related to gating that module on std?

Can you merge this PR and open that as a separate issue?

@Person-93
Person-93 force-pushed the no_std_broken_on_main branch from af8c4b8 to f0dd02c Compare September 11, 2026 02:19
@davidhewitt davidhewitt added the no_std Require `no_std` builds to pass label Sep 12, 2026
Comment thread tests/ui/invalid_pyclass_new.stderr Outdated
Comment thread tests/ui/invalid_property_args.no_std.stderr Outdated
@davidhewitt
davidhewitt added this pull request to the merge queue Sep 12, 2026
Merged via the queue into PyO3:main with commit 6a930e9 Sep 12, 2026
52 of 53 checks passed
@Person-93
Person-93 deleted the no_std_broken_on_main branch September 12, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no_std Require `no_std` builds to pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants