fix raw-dylib opt-out on windows x86 - #6410
Open
davidhewitt wants to merge 4 commits into
Open
davidhewitt wants to merge 4 commits into
davidhewitt wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #6389 - this PR applies the changes to
pyo3-ffi-check(with a FIXME for PyPy which that PR will resolve), CI andnoxfile.py, while leaving thepyo3-ffifixes for PyPy for the followup.The discovery in #6389 was that 32-bit windows' opt-out for
raw-dylibmerged in #6185 is slightly broken because the workaround for_link names is still applied. This PR fixes that.I think this'll also fix the 32-bit windows failure seen in PyO3/setuptools-rust#615