[WIP] Fix quantized (F)GW solvers - #857
Open
cedricvincentcuaz wants to merge 13 commits into
Open
cedricvincentcuaz wants to merge 13 commits into
cedricvincentcuaz wants to merge 13 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #857 +/- ##
=======================================
Coverage 96.85% 96.85%
=======================================
Files 128 128
Lines 26161 26161
=======================================
Hits 25337 25337
Misses 824 824 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Fix quantized (F)GW solvers that output mis-ordered indices in final OT plan (Issue #786 ).
Implies modifications of API, providing:
new parameters
part1andpart2as inputs toquantized_fused_gromov_wasserstein_partitioned. These variables were computed viaget_graph_partitionbut formatted as a list or array-like containing the node assignments. This has been reformatted as a list of array-like, where each array contains the indices of the nodes in the partition, to avoid redundant steps in the previous implementations.The construction of the transport plan in
quantized_fused_gromov_wasserstein_partitionedis support by two hidden functions_build_full_transport_by_assignment(numpy, torch - mutable) and_build_full_transport_by_concatenation(other non-mutable backends) to leverage a more memory-efficient approach for mutable backends.Motivation and context / Related issue
How has this been tested (if it applies)
PR checklist