Repository navigation
feat: add filter account capabiliity - #54
Conversation
n13
left a comment
There was a problem hiding this comment.
Reviewer model: GPT-6 Sol
Request changes: the production GraphQL connection is broken by this PR.
- [P0] Restore the public GraphQL endpoints —
src/components/common/network-provider/network-provider.tsx:7-8. Both built-in networks now point tohttp://127.0.0.1:8080/....NetworkProvidersupplies these URLs to the Apollo client insrc/providers.tsx, so each visitor's browser will query its own loopback address instead of the Quantus indexers. With no proxy running on that visitor's machine, account, transaction, and other Explorer data requests fail for both networks. Restore thehttps://sqm.quantus.com/v1/graphqlandhttps://sub2.quantus.com/v1/graphqldefaults; make any local proxy an explicit development-only option.
Validation: reviewed the diff at head 308d3208f438cb91d7a2e9b2f0bb0c91a5189f32 and traced the provider into Apollo; git diff --check passed. GitHub CI's build check passed, but the workflow does not run its test step. Local unit tests were unavailable because Bun and dependencies are not installed in the isolated worktree.
n13
left a comment
There was a problem hiding this comment.
Reviewer model: GPT-6 Sol
Approve: the account-type filters, query paths, and pagination at head 5237f6d4c72f24771b99c8f5b4c2387eb6bd9ca4 have no blocking findings. The prior production-endpoint regression is fixed.
Validation: git diff --check passed; 65 focused Bun tests passed across filter predicates, classification, pagination, transaction filters, and explain reporting; Prettier passed on the changed API, hook, filter, and UI files. Both public GraphQL endpoints accepted the new account/mined-block and transaction fields, and a representative filtered transaction query succeeded on sub2. The GitHub build and dependency checks passed.
Caveat: the CI workflow's test step is disabled. The repository's Jest command fails before test collection on its existing TypeScript setup file; the focused tests above passed with Bun's test runner.
Summary
Adding filter account to both transactions list page and account list page