Repository navigation
feat: update filter query - #55
Merged
Merged
Conversation
n13
approved these changes
Oct 3, 2026
n13
left a comment
There was a problem hiding this comment.
Reviewer model: GPT-6 Astra
Approve — no blocking findings in 2579532eeb24c79f9d89cc4b1049d8d23048a34c against base e939db480bf3adf6910afbedc591554aa6dbd566.
The account queries, list/detail labels, and shared account/transaction type filters consistently use has_mined_blocks. The generated schema exposes a non-null Boolean and its comparison input; the removed generated account documents have no remaining consumers.
Validation:
- Frozen-lockfile dependency installation succeeded with lifecycle scripts disabled.
bun test src/api/accounts.test.ts src/utils/account-type-filter.test.ts src/utils/classify-account-address.test.ts: 41 passed, 0 failed.bun run build: passed, including TypeScript checking.git diff --check: passed.- Executed the actual list, detail, and both encrypted-account filter queries successfully against Mainnet and Planck.
- Compared the flag with
minedBlocks(limit: 1)for 100 mined and 100 non-mined accounts on each network: 400 sampled accounts, no mismatches. This was a bounded sample, not an exhaustive backfill audit. - Checked all 96 generated query mappings against their document definitions.
Both GitHub checks are successful. Local commands used Bun 1.4.2 via npx --yes bun; the CI job named “Build and Test” currently runs the build, with the focused tests verified separately above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.