Skip to content

feat: update filter query - #55

Merged
dewabisma merged 1 commit into
mainfrom
beast/update-account-filter-query
Oct 3, 2026
Merged

dewabisma merged 1 commit into
mainfrom
beast/update-account-filter-query

Conversation

@dewabisma

Copy link
Copy Markdown
Collaborator

No description provided.

@dewabisma
dewabisma requested a review from n13 October 3, 2026 09:16

@n13 n13 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer model: GPT-6 Astra

Approve — no blocking findings in 2579532eeb24c79f9d89cc4b1049d8d23048a34c against base e939db480bf3adf6910afbedc591554aa6dbd566.

The account queries, list/detail labels, and shared account/transaction type filters consistently use has_mined_blocks. The generated schema exposes a non-null Boolean and its comparison input; the removed generated account documents have no remaining consumers.

Validation:

  • Frozen-lockfile dependency installation succeeded with lifecycle scripts disabled.
  • bun test src/api/accounts.test.ts src/utils/account-type-filter.test.ts src/utils/classify-account-address.test.ts: 41 passed, 0 failed.
  • bun run build: passed, including TypeScript checking.
  • git diff --check: passed.
  • Executed the actual list, detail, and both encrypted-account filter queries successfully against Mainnet and Planck.
  • Compared the flag with minedBlocks(limit: 1) for 100 mined and 100 non-mined accounts on each network: 400 sampled accounts, no mismatches. This was a bounded sample, not an exhaustive backfill audit.
  • Checked all 96 generated query mappings against their document definitions.

Both GitHub checks are successful. Local commands used Bun 1.4.2 via npx --yes bun; the CI job named “Build and Test” currently runs the build, with the focused tests verified separately above.

@dewabisma
dewabisma merged commit 6861302 into main Oct 3, 2026
2 checks passed
@dewabisma
dewabisma deleted the beast/update-account-filter-query branch October 3, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants