Skip to content

feat: subtle ux improvement - #58

Merged
dewabisma merged 2 commits into
mainfrom
beast/subtle-ux-improvement
Oct 5, 2026
Merged

dewabisma merged 2 commits into
mainfrom
beast/subtle-ux-improvement

Conversation

@dewabisma

Copy link
Copy Markdown
Collaborator

No description provided.

@dewabisma
dewabisma requested a review from n13 October 5, 2026 08:52

@n13 n13 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer model: GPT-6.1 Sol

APPROVE — No blocking findings at f5439058febb2b18b54f8a7458aeb464b9f52f93.

Reviewed the complete six-file diff and affected query, table, address-rendering, and multisig-navigation call paths. The fee query and column removals are consistent, and the multisig navigation changes preserve scroll position.

Validation:

  • git diff --check: passed.
  • npx --yes bun@1.2.16 run build: passed (Vite production build and TypeScript).
  • npx --yes bun@1.2.16 test src/utils/unified-transaction-filters.test.ts src/utils/formatter.test.ts: 17 passed, 0 failed.
  • Confirmed the production bundle uses both public HTTPS GraphQL endpoints.
  • Both GitHub checks passed for the reviewed head.

Limitation: the AccountAddressCell component suite could not execute with the checked-in Jest setup (Cannot use import statement outside a module in jest.setup.ts); that setup and test are unchanged by this PR.

@dewabisma
dewabisma merged commit a7dfd78 into main Oct 5, 2026
2 checks passed
@dewabisma
dewabisma deleted the beast/subtle-ux-improvement branch October 5, 2026 10:17
@dewabisma dewabisma mentioned this pull request Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants