Add private comments and anonymous actions - #165
Conversation
|
I got a bit confused on the branch i was supposed to open the pr on, woops |
| RankingQueueActionOnHold | ||
| RankingQueueActionVote | ||
| RankingQueueActionResolved | ||
| RankingQueueActionPrivate |
There was a problem hiding this comment.
Curious why we should have a new action if we already have is_anonymous?
Wouldn't it make more sense to do RankingQueueActionComment and set is_anonymous to true and just use that?
There was a problem hiding this comment.
@Swan we want it as new action, because when RS submits it, it wont take any real action to the ranking.
Its just to notify internally that the RS does not know what they wanna do with the mapset/does not know how to handle it.
Where if multiple of those are submitted then an HRS can deny the mapset.
There was a problem hiding this comment.
Alternatively we can just name it as Comment instead Private + the option for it to be anonymous or public.
There was a problem hiding this comment.
we want it as new action, because when RS submits it, it wont take any real action to the ranking.
RankingQueueActionComment isn't a real action. It's just a comment. So having that with an anonymous flag should still give what you want - an anonymous comment.
Where if multiple of those are submitted then an HRS can deny the mapset.
Just check for multiple anonymous comments?
There was a problem hiding this comment.
Fair forgot comments exists.
For now we want to try manually I think, we can make it automated eventually.
3 participants
Changes needed for new site feature, allowing RS to take action anonymously.