Skip to content

Fix finalizer detection for custom types - #29

Merged
Fernthedev merged 3 commits into
QuestPackageManager:masterfrom
FrozenAlex:fix-finalizers
Sep 28, 2026
Merged

Fernthedev merged 3 commits into
QuestPackageManager:masterfrom
FrozenAlex:fix-finalizers

Conversation

@FrozenAlex

Copy link
Copy Markdown

Determine has_finalize from the resolved System.Object.Finalize vtable slot instead of the overriding method’s name.

This recognizes renamed and inherited finalizers, including delegate wrapper destructors and DECLARE_SIMPLE_DTOR, allowing GC to release native resources that previously leaked.

Adds nine registration regression checks. Headset verification confirmed cleanup for both delegate wrappers, simple and renamed destructors, and inherited finalizers.

@Fernthedev
Fernthedev merged commit 224b41c into QuestPackageManager:master Sep 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants