Repository navigation
feat: add Astro 7 support on integration v1 - #293
Conversation
🦋 Changeset detectedLatest commit: 2e5c899 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
440db42 to
840533f
Compare
|
Thanks a lot for the Astro 7 update — I really appreciate the work here. I’ll test the integration thoroughly before integrating it. One thing I’d like to adjust first: the current v1 already targets Qwik 2.0 beta, while v2 is intended for the stable Qwik release. So this Astro 7 compatibility update should remain on the v1 version line, with the appropriate patch/minor bump rather than moving directly to v2. I’ll also update Panam to properly handle the cross-runtime script execution used by the CLI, which should address the current CI workflow issues around script execution. Once these changes are in place, I’ll take care of testing the CLI and integration across the relevant runtimes, templates and adapters before we merge. Thanks again for the contribution! |
|
Thanks for the clarification. Updated in 2e5c899: the integration changeset is now a v1 minor release, generated Astro 7 templates require @qwik.dev/astro ^1.1.0, and the docs clarify that integration v2 is reserved for stable Qwik v2. I left the Panam cross-runtime work out of this PR as requested. |
|
I verified the Vite 8 paths on the current head ( Environment: Ubuntu 26.04 ARM64, Node 26.7.0, Astro 7.2.4, Vite 8.2.2. I used pnpm 9.15.9 for the CLI suite to match CI. Tests
That is the complete 22/22 platform suite on the current head. The normal Playwright installer does not support Ubuntu 26.04 ARM64, so I downloaded Playwright's exact Chromium 145 ARM64 build to a temporary directory for those two tests. The previous approved CI run also passed 143/143 CLI and 22/22 platform tests. Apps and live smoke tests
All four builds generated populated Qwik manifests ( Notes
I did not find a Vite 8 compatibility regression or a merge blocker in the integration. Based on these tests, I don't think further changes are needed for this PR; the warnings above can be handled independently if desired. |
|
Thanks again for the update. Everything looks good now, and I’m going to merge this PR. The pnpm build-script restriction you mentioned is exactly the issue I’m going to address separately in Panam. Recent package-manager security changes, driven by the latest security incidents and vulnerabilities in the npm ecosystem, now require explicit handling/approval of dependency scripts. This isn’t an integration or PR issue; Panam needs to account for these newer package-manager execution policies across Node.js, Deno and Bun. I’ll handle that separately after merging. Thanks for the work — merging now. |
|
Thanks @siguici for the review! I wonder if you could help cut a release for Thanks in advance! |
It was fixed by @thejackshelton ✅ |
Summary
Testing
pnpm --filter @qwik.dev/create-astro checkpnpm exec vitest run libs/qwikdev-astro/tests/unit --reporter=verbose(12 passed)pnpm -C libs/create-qwikdev-astro tsx bin/test.ts --groups 'Astro 7 templates'(10 passed)pnpm exec playwright test --project=dev --project=static --project=node --project=vercel --project=netlify(20 passed)Fixes #290