Skip to content

fix mcp setup add local or user setting - #157

Open
RedTanny wants to merge 1 commit into
RHEcosystemAppEng:mainfrom
RedTanny:fix-mcp-setup
Open

fix mcp setup add local or user setting#157
RedTanny wants to merge 1 commit into
RHEcosystemAppEng:mainfrom
RedTanny:fix-mcp-setup

Conversation

@RedTanny

@RedTanny RedTanny commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Update the red-hat-security-mcp-setup skill so the Red Hat Security MCP
server can be installed at either the project level or the user
level
, for whichever agentic tool is running (Claude Code, Cursor, or
other). Previously the skill only wrote to the current project's
.mcp.json. It now:

  • Asks the user to choose project- vs. user-level install.
  • Detects the current tool and resolves the correct target config path
    (e.g. .cursor/mcp.json vs ~/.cursor/mcp.json for Cursor,
    .mcp.json vs ~/.claude/.mcp.json for Claude Code).
  • Locates the red-hat-security server entry from the plugin's
    vendor-specific com.<vendor>/mcp.json, falling back to the
    plugin-root mcp.json, then to an inline skeleton.
  • Merges that entry into the resolved target file without clobbering
    existing servers.

Pack(s) affected

  • ocp-admin
  • rh-ai-engineer
  • rh-automation
  • rh-basic
  • rh-developer
  • rh-sre
  • rh-virt
  • Other / repo-wide

Change type

  • New skill
  • New agent
  • New pack
  • Update existing skill / agent
  • MCP server config (mcps.json)
  • Docs / README
  • CI / tooling

Contribution method

  • Created/imported with /agentic-contribution-skill
  • Manual contribution (validated with make validate + make validate-skill-design-changed)

Pack-persona alignment (new skills only)

N/A — this updates an existing skill in rh-basic; no new skill or pack alignment question applies.

AGENTS.md compliance

  • Agents orchestrate skills; no direct MCP/tool calls in agents
  • Skills are single-purpose task executors
  • Skills encapsulate all tool access (MCP tools invoked only inside skills)
  • Document consultation: file is read with the Read tool, then declared to the user
  • No credentials hardcoded; env vars used via ${VAR} references
  • Human-in-the-loop confirmation added for any destructive or critical operations

Validation

  • make validate passes locally
  • New/changed skills have valid YAML frontmatter (name, description)
  • New/changed agents have valid YAML frontmatter (name, description)


Look for the `red-hat-security` entry to merge, in this order:

1. `$PLUGIN_ROOT/com.<vendor>/mcp.json` — the namespace dir for the

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$PLUGIN_ROOT is never defined


## Step 4 — Merge the entry into the target file

If `$MCP_FILE` (resolved in Step 2) exists: read it and merge in the

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$MCP_FILE is not defined either

Look for the `red-hat-security` entry to merge, in this order:

1. `$PLUGIN_ROOT/com.<vendor>/mcp.json` — the namespace dir for the
currently executing tool (e.g. `./com.cursor.editor/mcp.json`,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is an error on not, but I was expecting to see those dirs created on the PR. AM I wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants