feat(ci): enforce Compass lifecycle ceiling in CI validation - #158
Open
rhartuv wants to merge 1 commit into
Open
feat(ci): enforce Compass lifecycle ceiling in CI validation#158rhartuv wants to merge 1 commit into
rhartuv wants to merge 1 commit into
Conversation
rhartuv
requested review from
dmartinol,
ikrispin and
nemerna
as code owners
September 9, 2026 15:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enforces the Compass lifecycle ceiling rule in CI: a child skill cannot have a more mature
spec.lifecyclethan its parent plugin (pack).This PR adds programmatic validation and wires it into the existing Tier 2 structure checks. No new GitHub Actions workflow is introduced — the check runs automatically via
make validate-structureintier-2-check.yaml.Background
By design, skill lifecycle maturity must not exceed the pack plugin lifecycle:
development(0) <beta(1) <production(2)developmentdeprecatedskills and plugins are skippedThis rule was previously documented and enforced manually. Data fixes were already applied to bring manifests into compliance; this PR prevents future regressions.
Prior data fixes (compliance groundwork)
Manifest data was corrected before adding enforcement:
development→betato match child skills (ocp-admin,rh-basic,rh-sre,rh-virt)This PR adds the validator only; it does not change lifecycle values in manifests.
Changes
Dependency update
pytest>=8.0to the dev dependency group inpyproject.tomluv.lockValidator (
scripts/validate_lifecycle_ceiling.py)catalog-info.yamlspec.targets(same convention asvalidate_compass_manifests.py)<pack>/<pack>-plugin.yamlskill_rank <= plugin_rankdevelopmentdeprecatedskills and pluginsUnit tests (
scripts/test_validate_lifecycle_ceiling.py)validate_alldiscovery and error handlingMakefile / CI integration
validate-lifecycle-ceilingtargetvalidateandvalidate-structuretier-2-check.yaml(make install && make validate-structure)Test plan
uv run python scripts/validate_lifecycle_ceiling.py— passes on current manifestsuv run pytest scripts/test_validate_lifecycle_ceiling.py -v— 18 tests passmake validate-lifecycle-ceiling— passesmake validate-structure— passes (CI path)make validate— passes