Set reduction thresholds for block size and block algo - #5162
Draft
TedThemistokleous wants to merge 2 commits into
Draft
Set reduction thresholds for block size and block algo#5162TedThemistokleous wants to merge 2 commits into
TedThemistokleous wants to merge 2 commits into
Conversation
… seen in customer models
Check flagged results 🔆 * No develop baseline was found for this PR's branch point; compared against the latest available develop run instead. |
|
tamahedi
reviewed
Aug 21, 2026
tamahedi
left a comment
Contributor
There was a problem hiding this comment.
Built and tested on strix halo - it allows the model to compile and run as expected, also not causing reboots on modelbench.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue with reductions causing kernel blow ups with groupnorm_silu seen in customer models
Was seeing blow up during compile of customer models when selecting block size and block_algo
Added thresholds to generate more reasonable bounds so we don't create large reductions that blow over memory bounds.
Iterated with cursor on this one to get the result. Putting this as draft to sanity check/get reviews.
Got to this concolusion by doing the following with cursor.
Potential relevant fix to - #5052
Original tested this on Navi3x where I was able to repro the isssue with the added unit tests and then verify fix works. @tamahedi @tperry-amd give this a try in your setup with a cherry-pick and see if this resolves your case on Strix workflow.
Motivation
Technical Details
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot ApplicableFollow the LLVM AI Tool Use Policy for contributions using AI.