CI: parallel download steps, bump {up,down}load-artifacts versions - #719
Conversation
There was a problem hiding this comment.
Pull request overview
Parallelizes artifact downloads and Docker image pulls to reduce ROCm CI startup time while updating artifact actions to Node.js-compatible releases.
Changes:
- Run artifact download and Docker pull steps concurrently.
- Upgrade upload/download artifact actions to v7/v8.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/rocm-wheels-build.yml |
Upgrades artifact uploads to v7. |
.github/workflows/rocm-ci.yml |
Parallelizes setup operations and upgrades artifact actions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| 3rdparty/googletest \ | ||
| 3rdparty/hipify_torch | ||
|
|
||
| - name: Download build artifacts |
There was a problem hiding this comment.
It is good change. Will it be also beneficial to put other downloads to this parallel step: repo checkout + submodules init?
There was a problem hiding this comment.
From what I have seen, these steps are quite fast already (<10s each):

Checkout probably can't share the group with the download, since it runs git clean and that might race with the artifact download to dist/.
We could:
- run
docker pullas the first step, in the background (it needs nothing from the repo) - run
checkout,submodule init,artifact downloadsequentially (but in parallel to the backgroundeddocker pull)
I'm doubtful that the added complexity would be worth it.
Description
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: