Conversation
…fault level, ERROR
jclerman
requested changes
Oct 1, 2026
jclerman
left a comment
Collaborator
There was a problem hiding this comment.
I would not merge this. Multiple logical definitions on a single class can actually be quite informative, e.g.
left knee
== knee and (part_of some left leg)
== knee and (part of some left side of body)
The argument for this rule in the ROBOT docs is vague (to me), and I've found considerable utility in the kinds of constructions it prohibits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5.
multiple_equivalent_class_definitionsROBOT's standard check, at its default level (ERROR). Nothing on
mainfails it, so no data changes. All tests pass.