Repository navigation
docs: update the testing instructions to be current and concise - #631
Merged
Merged
Conversation
|
Review changes with Changed Files
|
Contributor
|
joanise
force-pushed
the
dev.ej/improve-test-instructions
branch
from
October 21, 2026 20:35
44f6bf6 to
1e44207
Compare
Some verbose text is now shorter and clearer Race condition between building web-component and studio-web is removed We now run just the processes we need to run Drop Python 3.8 from the web-api requirements, now we need 3.9+
joanise
force-pushed
the
dev.ej/improve-test-instructions
branch
from
October 21, 2026 21:54
1e44207 to
c46b8bc
Compare
We do not actually test with WebKit because we are not compatible with it, so let's not ask testers to install it.
joanise
force-pushed
the
dev.ej/improve-test-instructions
branch
from
October 22, 2026 20:17
3ec0e13 to
aff04f3
Compare
…wline Our pre-commit hooks add the final newline if missing when we commit, but update-translations.sh leaves them out, which means Git will always say three files are out of date, which are then reset by pre-commit. That is somewhat annoying, let us instead produce the files directly in the standardized format so git status can immediately confirm nothing actually changed. Claude Opus 5.5 helped with modifying the extract-i18n target to append a newline.
joanise
force-pushed
the
dev.ej/improve-test-instructions
branch
from
October 22, 2026 20:38
aff04f3 to
a6339c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
Some issues raised by MT, so more stuff I noticed while in there:
Feedback sought?
Are these instructions clearer and do they resolve the issues you told me about?
Priority?
medium -- before I publish 1.6.5
Tests added?
n/a
How to test?
follow the instructions in the README and make sure they work as expected.
Confidence?
high
Version change?
soon come