Skip to content

fix: reset package name in intent on open link error #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NatsuCamellia wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: reset package name in intent on open link error #1320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bf7a81
fix: reset package name in intent on open link error
NatsuCamellia Aug 23, 2026
ff9f736
fix: show a toast instead of crashing when no app can open a link
NatsuCamellia Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions app/src/main/java/me/ash/reader/infrastructure/compose/UriHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,13 @@ internal class AppUriHandler(
}
}
} catch (_: Throwable) {
showToast(getString(R.string.open_link_something_wrong))
startActivity(intent)
val fallbackIntent = intent.setPackage(null)
if (fallbackIntent.resolveActivity(packageManager) != null) {
showToast(getString(R.string.open_link_something_wrong))
startActivity(fallbackIntent)
} else {
showToast(getString(R.string.open_link_no_app_found))
}
}
}
}
Expand Down
9 changes: 7 additions & 2 deletions app/src/main/java/me/ash/reader/ui/ext/ContextExt.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,13 @@ fun Context.openURL(

}
} catch (_: Throwable) {
showToast(getString(R.string.open_link_something_wrong))
startActivity(intent)
val fallbackIntent = intent.setPackage(null)
if (fallbackIntent.resolveActivity(packageManager) != null) {
showToast(getString(R.string.open_link_something_wrong))
startActivity(fallbackIntent)
} else {
showToast(getString(R.string.open_link_no_app_found))
}
}
}
}
Expand Down
1 change: 1 addition & 0 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,7 @@
<string name="always_ask">Always ask</string>
<string name="open_link_specific_browser">Browser</string>
<string name="open_link_something_wrong">\"Open link\" setting ignored because something went wrong</string>
<string name="open_link_no_app_found">No app found to open this link</string>
<string name="open_link_ask_dialog_title">Open with…</string>
<string name="include_additional_info">Include additional info</string>
<string name="exclude">Exclude</string>
Expand Down
Loading