fix(cluster-manager): announce only persisted endorsement changes - #1
Merged
Merged
Conversation
Emit truststore change announcements only after an endorsement merge adds and persists a new endorsement. Keep idempotent re-pins, empty or duplicate merges, and failed writes silent, with component-level regression and race coverage. Signed-off-by: Josh Stevenson <j.stevenson.cs@gmail.com>
Signed-off-by: Josh Stevenson <j.stevenson.cs@gmail.com>
Verify callback read-back and disk reload for direct and identical-pin merges, including mixed and duplicate batches. Exercise replace failures through both entry points, preserve old disk and live state, and verify recovery without temporary residue. Add concurrent identical submissions and missing-target regression coverage. Signed-off-by: Josh Stevenson <j.stevenson.cs@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nvpair-cluster-managerfrom1.1.4to1.1.5.This fork-local PR carries the truststore notification correction and its follow-up regression coverage into
RecursiveIntell/Personal-AI-Router. It is intentionally separate from NVIDIA PR NVIDIA#62; no action on the NVIDIA PR is part of this publication.The change is based on the existing PAIR truststore implementation in this fork and preserves the repository’s existing NVIDIA copyright and Apache-2.0 licensing notices. The correction commits and follow-up tests are authored by Josh Stevenson.
Scope
Changed paths are limited to:
services/nvpair-cluster-manager/truststore.goservices/nvpair-cluster-manager/truststore_announce_test.goservices/versions.jsonThe change does not claim to strengthen cryptographic trust, pairing-PIN security, authorization, certificate validation, endorsement verification, or mTLS configuration.
Validation
Validated candidate head:
Base:
The candidate passed the cluster-manager normal and race suites,
go vet, formatting, diff checks, and JSON validation in the review environment. Retained validation records report additional repository and integration checks. Repository-widemake testremains non-green in retained records, involving VCS-stamping and LM Studio flush-deadline failures also reported on cleanmain; those failures are not attributed to this three-path correction.Separate private-fleet evidence reports the behavior patch active in a tested
1.1.5runtime. That runtime evidence is bound to source commit13b68115fa2c9c1d94f1ead1358f8d5a527cfecf. Candidate headda7df0aincludes the behavior correction, follow-up tests, and version metadata; the exact candidate head is not presented as the newly activated runtime.Publication boundary
This PR targets only:
No NVIDIA upstream branch, PR, review, comment, or merge is modified by this operation.