Fix worldscape mingw compilation and add CI job - #1366
Arctis-Fireblight merged 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (9)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. WalkthroughChangesThe Windows build matrix adds an editor build that uses MinGW GCC. WorldScape3D replaces the guarded Windows GCC editor build
WorldScape3D return macro migration
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The PR resolves a Windows SDK macro conflict while adding a focused MinGW editor build check; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 41.03% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 39 functions across 8 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c10d9f7 to
ee5802a
Compare
Urgent fix to fix cross-compiling the editor on Linux for Windows.
Worldscape defined a
VOIDmacro in its constants header, which conflicts with MinGW's windows SDK, causing compilation to fail due to loss of common types likeCHAR.This prevents the Windows Editor specifically from being able to be compiled on a Linux host, preventing our release infrastructure from working.
Also added a GH Action for building the Editor with MinGW to prevent issues like this from happening again in the future. As the existing GH Action that tests MinGW only compiles the release template, not the editor. Which is why this was not caught during review and testing of the Worldscape3D PR, as this was not an issue with MSVC, Clang, or GCC.Tested locally and I was able to compile the editor with MinGW with this fix.
I will be merging this as soon as all GHA jobs complete as this is currently holding up the 26.3 beta.
EDIT: The workflow that was added to build the editor using MinGW took an hour and a half.
I have removed that commit from this PR as that sort of compile time is completely unacceptable.
Going forward I want to explore other options for cross compiling.
Summary by CodeRabbit