Fix decreasing ReflectionProbe's intensity property below 1.0 not reducing the strength of its ambient light condition

[DaveTheEggman]

The Forward+/Mobile shader never multiplies the ambient lighting contribution by reflections.data[ref_index].intensity. As a result, reducing a ReflectionProbe's intensity below 1.0 only affects reflected light, while the ambient contribution remains unchanged. This PR applies the intensity multiplier to the ambient contribution as well.

Before (Forward+/Mobile)	After (Forward+/Mobile)

MRP

test_reflection_probe_intensity.zip

AI Disclosure:

This PR doesn't use AI, it's all human written code & same goes for the desc 🙃

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

• servers/rendering/renderer_rd/shaders/scene_forward_lights_inc.glsl is excluded by !**/*.glsl

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: db8dba91-c95d-402c-b0f7-6613fc131b62

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Arctis-Fireblight]

LGTM