Repository navigation
ci: the daily report pull request passes the changelog and label checks and never cuts a release - #807
Merged
Conversation
…ks and never cuts a release
Contributor
PR Quality ReportCompared against base branch Coverage and tests
Compatibility
Performance smokePerformance smoke was skipped for this PR because no perf-sensitive paths changed. State
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The daily performance report pull request only changes measurement data, but three checks treated it like a code change. On #781 and #805,
changelogandlabelfailed, and merging #805 nearly cut a second release (stopped withno-release). This PR fixes those three checks.bench/ab/history/,bench/ab/results/and the three reports the run regenerates (conformance/registry/generated/perf-evidence.json,conformance/reports/performance.md,conformance/reports/gaps.md) count as non-release, likedocs/.bench/ab/*.py), the registry sources and the registry's other generated files (for examplegenerated/proxy/limits.json, exported from the flags) still require an entry.auto-release.yaml): the same files count as docs and CI changes. Merging a report therefore never cuts a release, even while[Unreleased]holds entries from an earlier pull request.gh pr diff --name-onlyfails once a diff passes GitHub's 20,000-line limit (HTTP 406 … too_large), which every daily report does.Changes
scripts/ci/check_changelog_pr.py: two path prefixes and three files added to the non-release lists.scripts/ci/tests/test_check_changelog_pr.py, two new tests:generated/proxy/limits.jsonstill do..github/workflows/auto-release.yaml: the docs/CI-only regex now includes the same paths..github/workflows/pr-labeler.yaml: the file list comes fromgh api --paginate repos/…/pulls/N/files.CHANGELOG.md: a CI entry under[Unreleased].Proofs
80e94721..f6f6455): the gate frommainfails ("CHANGELOG.md must be updated"), and the new gate prints "skipped (no releasable changes detected)". fix(security): resolve the open Semgrep code-scanning alerts in the release workflows and the unwrap check #804's range (80e94721..a5740e1d) still passes as a release entry.v2.24.4..58be7559(bench: daily performance report 2026-10-22 #805's merge): every file matches, so the release is skipped;v2.24.3..a5740e1d(fix(security): resolve the open Semgrep code-scanning alerts in the release workflows and the unwrap check #804): still releases;bench/ab/daily.py,conformance/registry/baseline.jsonandconformance/registry/generated/proxy/limits.json: still release.gh pr diff --name-onlyexits 1, and the files API returns all 45 files. On fix(security): resolve the open Semgrep code-scanning alerts in the release workflows and the unwrap check #804, both give the same 6 files.bench/ab/andconformance/turns the new harness test red.scripts/ci/tests: 79 tests pass;Not applicable: no proxy code changes, so e2e vs Loki, the Grafana range matrix, visual proof, A/B, benchstat and the load test do not apply.
Notes:
scripts/ci/is outside the docs/CI-only paths, so merging this PR cuts a patch release and opens its metadata PR.performance(from thebench:title) andscope/docs(fromtrend.md). The release skip runs before the label-based version bump, so these labels never trigger a release.