Skip to content

ci: the daily report pull request passes the changelog and label checks and never cuts a release - #807

Merged
szibis merged 1 commit into
mainfrom
ci/daily-report-pr-checks
Oct 22, 2026
Merged

szibis merged 1 commit into
mainfrom
ci/daily-report-pr-checks

Conversation

@szibis

@szibis szibis commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

The daily performance report pull request only changes measurement data, but three checks treated it like a code change. On #781 and #805, changelog and label failed, and merging #805 nearly cut a second release (stopped with no-release). This PR fixes those three checks.

  • Changelog gate: bench/ab/history/, bench/ab/results/ and the three reports the run regenerates (conformance/registry/generated/perf-evidence.json, conformance/reports/performance.md, conformance/reports/gaps.md) count as non-release, like docs/.
    • The harness (bench/ab/*.py), the registry sources and the registry's other generated files (for example generated/proxy/limits.json, exported from the flags) still require an entry.
  • Release bot (auto-release.yaml): the same files count as docs and CI changes. Merging a report therefore never cuts a release, even while [Unreleased] holds entries from an earlier pull request.
    • Before this change, the bot would have cut a release, and a report diff counts as a large change, so it would have been a minor one.
  • Labeler: reads the file list from the paginated pull request files API. gh pr diff --name-only fails once a diff passes GitHub's 20,000-line limit (HTTP 406 … too_large), which every daily report does.

Changes

  • scripts/ci/check_changelog_pr.py: two path prefixes and three files added to the non-release lists.
  • scripts/ci/tests/test_check_changelog_pr.py, two new tests:
  • .github/workflows/auto-release.yaml: the docs/CI-only regex now includes the same paths.
  • .github/workflows/pr-labeler.yaml: the file list comes from gh api --paginate repos/…/pulls/N/files.
  • CHANGELOG.md: a CI entry under [Unreleased].

Proofs

Not applicable: no proxy code changes, so e2e vs Loki, the Grafana range matrix, visual proof, A/B, benchstat and the load test do not apply.

Notes:

  • Merging cuts a release: scripts/ci/ is outside the docs/CI-only paths, so merging this PR cuts a patch release and opens its metadata PR.
  • Daily PRs still need an admin merge: the bot's report commit stays unsigned. Creating it through GitHub's API is a separate change, made after testing on a scratch branch: the payload is several MB and grows every day, and the branch reset has to be safe while a report PR is open.
  • New labels: daily PRs will now also get performance (from the bench: title) and scope/docs (from trend.md). The release skip runs before the label-based version bump, so these labels never trigger a release.

@github-actions github-actions Bot added size/M Medium change scope/ci CI/CD scope/docs Documentation maintenance Maintenance labels Oct 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR Quality Report

Compared against base branch main.

Coverage and tests

Signal Base PR Delta
Test count 11827 11827 0
Coverage 88.3% 88.3% 0.0% (stable)

Compatibility

Track Base PR Delta
Loki API 100.0% 11/11 (100.0%) 0.0% (stable)
Logs Drilldown 100.0% 17/17 (100.0%) 0.0% (stable)
VictoriaLogs 100.0% 11/11 (100.0%) 0.0% (stable)

Performance smoke

Performance smoke was skipped for this PR because no perf-sensitive paths changed.

State

  • Coverage, compatibility, and sampled performance are reported here from the same PR workflow.
  • This is a delta report, not a release gate by itself. Required checks still decide merge safety.
  • Performance smoke was intentionally skipped because no perf-sensitive paths changed in this PR.
  • Delta states use the same noise guards as the quality gate (percent + absolute + low-baseline checks), so report labels match merge-gate behavior.

@szibis
szibis merged commit 0638246 into main Oct 22, 2026
38 checks passed
@szibis
szibis deleted the ci/daily-report-pr-checks branch October 22, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Maintenance scope/ci CI/CD scope/docs Documentation size/M Medium change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant