Repository navigation
ci: give the compose validation a placeholder peer token - #826
Merged
Merged
Conversation
The four peer example stacks now require PEER_AUTH_TOKEN, so validate_compose.sh failed on them and the lint job failed on every pull request. The script sets a placeholder when the variable is unset; config only interpolates it and starts nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lintfails on every pull request since #822. Its compose validation runsdocker compose config -qon the fourexamples/peers/*stacks, which requirePEER_AUTH_TOKENsince #819, so each one fails withrequired variable PEER_AUTH_TOKEN is missing a value. The two pull requests were built in parallel and the script never ran against the new examples.scripts/ci/validate_compose.shnow exports a placeholderPEER_AUTH_TOKENwhen it is unset.configonly interpolates it; no container starts.Proofs
mainfails locally on the four peer stacks with the same error as CI (run 39783988802, joblint).validated 15 compose stacks, exit 0, including withPEER_AUTH_TOKENunset. shellcheck is clean.PEER_AUTH_TOKENis the only${VAR:?}in any tracked compose file.Not applicable: infra-only PR; product checks (e2e vs Loki, Grafana range matrix, visual, A/B, benchstat, load) do not apply. This PR is infra-only, so its own run is the first to show the product jobs skipped by #822 and #823.