Skip to content

为 rsync 官方下载的 HTTP 504 增加有限重试 - #18

Merged
tiye merged 1 commit into
mainfrom
fix-rsync-download-retry-499
Oct 27, 2026
Merged

tiye merged 1 commit into
mainfrom
fix-rsync-download-retry-499

Conversation

@tiye

@tiye tiye commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

使用者影响:修复迁移后 main CI 因 rsync 官方下载暂时返回 HTTP 504 而中断的问题,不改变应用、文档内容或 Calcit 类型合同。失败记录:https://github.com/Respo/guidebook/actions/runs/40504890020 。

只给原 curl 命令增加最多 3 次重试、间隔 5 秒。仍使用原官方地址、固定 rsync 3.4.4 和 SHA-256 校验,保留构建/严格类型检查及 job 超时,不增加脚本、忽略错误或改成未校验镜像。持续失败仍令 CI 失败。

PR 仅运行原构建和保存预览 artifact,不上传 COS 或执行 rsync;未重跑失败的生产工作流,未合并部署。合并后原 main 会部署,届时另核对授权。验证以本 PR 原完整 CI 为准;源码和类型门禁没有改动。

Summary by CodeRabbit

  • Bug Fixes
    • Downloads now retry up to three times, with a five-second wait between attempts, helping recover from temporary failures.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: deab399f-5ad7-4e98-a002-495ca37e91e0
Commits

Reviewing files that changed from the base of the PR and between c41ca41 and e74ff9d.

Files selected for processing: 1
  • .github/workflows/upload.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The upload workflow’s rsync archive download now retries up to three times, with a five-second delay between retries.

Changes

Workflow download

Layer / File(s) Summary
Configure download retries
.github/workflows/upload.yaml
The rsync archive download command adds up to three retries with a five-second delay. It retains the existing failure, redirect, and output options.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: Minimal · up to e74ff

The bounded download retry improves resilience while preserving failure handling and checksum verification.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed 标题准确概括了主要变更:为官方 rsync 下载遇到 HTTP 504 增加有限重试。
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tiye
tiye merged commit 5d3c4ab into main Oct 27, 2026
1 check passed
@tiye
tiye deleted the fix-rsync-download-retry-499 branch October 27, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant