Skip to content

升级 Markup 到 Calcit 0.40.0 并约束编辑操作载荷 - #24

Merged
tiye merged 1 commit into
mainfrom
migrate/respo-types-0400
Nov 10, 2026
Merged

tiye merged 1 commit into
mainfrom
migrate/respo-types-0400

Conversation

@tiye

@tiye tiye commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

用户需要注意

从源码构建请配套安装 Calcit 与 procs 0.40.0。旧存档仍可读。旧编辑器数据若是 Struct,编辑后会写成保留原字段的 Map。

改动与风险

  • :states 编辑操作携带受检的状态 Map,游标继续使用 CoordKey。保留旧编辑器数据的附加字段和既有 HUD。
  • 读取旧存档本身维持原形状,只有编辑才写入规范化的数据。

验证

Caps、immutable 安装、完整 strict、原动态方法门禁、3 项 Reel/存档测试、构建通过。另通过生成 JS 验证旧编辑器 Struct 的真实输入回调保留额外字段。

Summary by CodeRabbit

  • Bug Fixes
    • Improved how saved state values are displayed and read when running the app, including handling missing values.
  • Documentation
    • Updated the documented Calcit version to 0.40.0.

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The project’s Calcit version references change from 0.38.0 to 0.40.0. Container state is decoded as a map, :content is handled as an option, and the :states operation payload is typed as a map.

Changes

Calcit Version and State Handling

Layer / File(s) Summary
Align Calcit versions
deps.cirru, package.json, README.md
The dependency manifest, package manifest, and README update their Calcit version references from 0.38.0 to 0.40.0.
Decode state and update operation payload
calcit.cirru
Container state is converted to a map and decoded as Map Dynamic Dynamic. The textarea receives the optional :content value or an empty option. The Run handler prints the value when present and nil when absent. The :states payload type changes from Dynamic to Map Dynamic Dynamic.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

  • Respo/markup#20: Updates comp-container to convert legacy Struct state to a Map and read :content as an option.
  • Respo/markup#22: Changes state handling for present and missing :content and narrows edit callbacks to app.schema/Op.
  • Respo/markup#23: Changes edit dispatch to use typed app.schema/Op values.
Merge Risk: Minimal · up to 39eb7

No concrete merge-blocking risk was identified in the upgrade or editor-state changes.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed 标题准确概括了主要改动:升级到 Calcit 0.40.0,并约束编辑操作载荷。
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 853d8ddf-51d5-44c7-b20b-97814c2af9f5
Commits

Reviewing files that changed from the base of the PR and between 07c84e4 and 39eb77d.

Files ignored due to path filters: 1

  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Files selected for processing: 4

  • README.md
  • calcit.cirru
  • deps.cirru
  • package.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@tiye
tiye merged commit 636afd3 into main Nov 10, 2026
1 check passed
@tiye
tiye deleted the migrate/respo-types-0400 branch November 10, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant