You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
No actionable comments were generated in the recent review.
Walkthrough
The editor container now reads editor data through schema/read-editor-data, decodes each value in :content as a string, and passes the mapped content directly to the textarea.
Changes
Editor content rendering
Layer / File(s)
Summary
Map and render editor content calcit.cirru
The container maps decode-map-as with String over :content and passes the result to the textarea. This replaces handling :content as an optional single value.
Respo/markup#27: Changes validation and decoding for the save body, which concerns the same content field.
Respo/markup#25: Changes the edit action and body type for the same content field.
Merge Risk: Minimal · up to fd992
The Markup editor now reads saved content through a validated decoding step. No actionable merge-blocking risk was identified in this change.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title says the Markup editor now uses the validated text in a unified way. The change decodes the stored content once through schema/read-editor-data and passes the result to the textarea. The…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title says the Markup editor now uses the validated text in a unified way. The change decodes the stored content once through schema/read-editor-data and passes the result to the textarea. The objectives say the input box and the Run button share the same validated text, and that the decoded content is an Option String used by rendering and click handling. The title matches this main change. The title is in Chinese, which fits the project's language of the PR objectives.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 0fd3071b-6c21-403a-9691-7c0a2e84185f
Commits
Reviewing files that changed from the base of the PR and between 6c36cac and fd9920b.
Files selected for processing: 1
calcit.cirru
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
使用者需要注意
编辑器仍读取原有存档,输入框和 Run 按钮使用同一份已校验文本。存档里的扩展字段仍可随状态保存。
改动与验证
Summary by CodeRabbit