You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Improved handling of saved application state addressed by numeric or string keys, including nested state. These states can now be decoded and restored with their contents preserved.
State addressed by boolean keys is rejected during decoding.
No actionable comments were generated in the recent review.
Walkthrough
The store state map and updater decoder now use respo.schema/CoordKey for keys. Tests cover accepted numeric and string keys, rejected boolean keys, and nested state preservation after an edit and serialization round trip.
Changes
Store state key types
Layer / File(s)
Summary
Coordinate-keyed store state calcit.cirru, scripts/typed-reel-render.test.mjs
Store.states and the updater decoder use respo.schema/CoordKey keys. Tests check numeric and string keys, reject boolean keys, and verify that nested editor content remains nested after an edit and serialization round trip.
This change tightens the key type of the state tree and adds regression tests for accepted and rejected keys. No concrete merge-blocking problem was found, and the risk of merging is minimal.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "用 CoordKey 约束 Markup 状态树根键" (Constrain Markup state tree root keys with CoordKey) matches the main change. The summary shows app.schema/Store.states changing from Map Dynamic Dynamic to…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "用 CoordKey 约束 Markup 状态树根键" (Constrain Markup state tree root keys with CoordKey) matches the main change. The summary shows app.schema/Store.states changing from Map Dynamic Dynamic to Map respo.schema/CoordKey Dynamic, and the objectives describe the same goal of sharing Respo's CoordKey type for archive decoding and state updates. The title is specific and consistent with the changeset. The test file changes support the same change but are secondary to it.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 4db60326-fb13-4ca9-82aa-a1d1a1a29426
Commits
Reviewing files that changed from the base of the PR and between 491c8a9 and fdd8e2c.
Files selected for processing: 2
calcit.cirru
scripts/typed-reel-render.test.mjs
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
用户影响
使用标签、字符串和数字状态键的 Markup 存档仍可直接恢复。若旧存档在 UI 状态树根层用了布尔值等不支持的键,页面会通过 HUD 提示并中止启动,原存档会保留。
改动与验证
CoordKey联合类型。编辑器扩展字段值仍按原格式保存。Summary by CodeRabbit