Repository navigation
Restore the saved viewport before replay anchor loading - #11
Merged
Merged
Conversation
mstan
marked this pull request as ready for review
November 7, 2026 04:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting an anchored replay initialized the core with an unavailable viewport, then adopted the recorded drawable size only on the first frame. A core that binds saved presentation history to the viewport could reject that history and diverge immediately.
Record the anchor's viewport in boot metadata and apply it before core initialization/loading. Keep each subsequent frame's recorded size, including a resize on the first field.
Validation: the fixture requires a 1440x900 viewport during anchor restore while its first field uses 640x480; it fails on the original code and passes with this change. Native Windows tests: 46 passed. Native Linux tests: 50 passed. Actual Smash Vulkan 4x/Fit replay with the normal density badge passes 200 picture/audio checkpoints in a fresh runner, linked playback to the recorded end, and takeover at field 40. No checkpoint comparisons were removed.