Repository navigation
Fix out-of-bounds access to override BOBs ny-offset - #1984
Merged
Merged
Conversation
Flamefire
enabled auto-merge (rebase)
September 24, 2026 17:18
In `glArchivItem_Bob::mergeLinks` the ny-offset array for additional Bobs was not resized leading to an OOB access when accessing the sprites after Return-To-The-Roots#1968 Fix by using a single array instead. Fixes Return-To-The-Roots#1982 Fixes Return-To-The-Roots#1983
Flamefire
force-pushed
the
fix-bob-crash
branch
from
September 24, 2026 17:18
072811f to
6e80cac
Compare
Flow86
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
glArchivItem_Bob::mergeLinksthe ny-offset array for additional Bobs was not resized leading to an OOB access when accessing the sprites after #1968Fix by using a single array instead.
Fixes #1982
Fixes #1983