feat(ui): add the dot-matrix Glyph primitive and its four chrome bitmaps (RIG-3736) - #1194
Merged
Merged
Conversation
|
😎 This pull request was merged. |
rigel-mintaka
marked this pull request as ready for review
September 12, 2026 23:50
|
Compass engineering docs preview: https://compass-ux-3736-glyph-primit.compass-eng-docs.pages.dev Deployed from Changed pages: |
rigel-mintaka
added this pull request to stack #1200
September 13, 2026 00:36
This was referenced Sep 13, 2026
mattwilkinsonn
approved these changes
Sep 13, 2026
…aps (RIG-3736) Adopts the DL-150 / DL-199 technique for UI chrome symbols: an 11x11 1-bit grid at one CSS px per cell, `shape-rendering="crispEdges"`, one `<rect width="1" height="1">` per lit cell filled on `currentColor` so the consuming control's color flows through. `GLYPH_CELLS` is keyed on the exhaustive `GlyphName` union, so a name without a bitmap is a compile error rather than a silent runtime blank — the guard `BadgeGlyph`'s `GlyphKey` already provides. The four canonical grids are transcribed into `design/components.md` §Glyphs, which stays the source of truth for the geometry. The glyph is decorative: `aria-hidden`, no `role="img"` and no `aria-label`. It carries no meaning of its own, so a name-bearing label belongs on the consuming control. This is the deliberate difference from `BadgeGlyph`, whose glyph encodes status. The `vcs` glyph is one orthogonally-connected shape: cells that touch only at a corner read as detached specks at 11px under `crispEdges`, not as a line, so the branch is fused to the trunk rather than meeting it diagonally. `status` and `pr` are deliberately multi-part (four blocks, two arrows). No call-site adopts `<Glyph/>` yet; `ActivityBarItem`, the render site, and the chrome audit follow in later commits of this stack. Ref: RIG-3736, RIG-3603. Design: docs/designs/ui/compass-glyph-primitives/design.md (DL-367). Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
force-pushed
the
compass-ux/3736-glyph-primitive
branch
from
September 13, 2026 22:06
b0fbcb3 to
288e9eb
Compare
|
This pull request was merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 5 PRs:
mainAdopts the DL-150 / DL-199 technique for UI chrome symbols: an 11x11 1-bit
grid at one CSS px per cell,
shape-rendering="crispEdges", one<rect width="1" height="1">per lit cell filled oncurrentColorso theconsuming control's color flows through.
GLYPH_CELLSis keyed on the exhaustiveGlyphNameunion, so a name withouta bitmap is a compile error rather than a silent runtime blank — the guard
BadgeGlyph'sGlyphKeyalready provides. The four canonical grids aretranscribed into
design/components.md§Glyphs, which stays the source oftruth for the geometry.
The glyph is decorative:
aria-hidden, norole="img"and noaria-label.It carries no meaning of its own, so a name-bearing label belongs on the
consuming control. This is the deliberate difference from
BadgeGlyph, whoseglyph encodes status.
The
vcsglyph is one orthogonally-connected shape: cells that touch onlyat a corner read as detached specks at 11px under
crispEdges, not as aline, so the branch is fused to the trunk rather than meeting it diagonally.
statusandprare deliberately multi-part (four blocks, two arrows).No call-site adopts
<Glyph/>yet;ActivityBarItem, the render site, andthe chrome audit follow in later commits of this stack.
Ref: RIG-3736, RIG-3603. Design: docs/designs/ui/compass-glyph-primitives/design.md (DL-367).
Co-authored-by: Matt Wilkinson matt@rigel.build