Repository navigation
feat(usage): record compute-usage intervals with the session binding (RIG-2872) - #1509
Merged
Merged
Conversation
|
Compass engineering docs preview: https://compass-server-rig-2872-comp.compass-eng-docs.pages.dev Deployed from Changed pages: |
rigel-mintaka
marked this pull request as ready for review
October 3, 2026 11:05
rigel-mintaka
force-pushed
the
compass-server/rig-2872-compute-intervals
branch
from
October 3, 2026 17:11
870fe85 to
232742c
Compare
Base automatically changed from
compass-server/rig-2872-token-usage-store
to
main
October 3, 2026 18:15
|
😎 Stack merged successfully - details. |
rigel-mintaka
force-pushed
the
compass-server/rig-2872-compute-intervals
branch
from
October 3, 2026 20:26
232742c to
01e0847
Compare
mattwilkinsonn
added this pull request to stack #1560
October 3, 2026 21:57
mattwilkinsonn
approved these changes
Oct 3, 2026
rigel-mintaka
force-pushed
the
compass-server/rig-2872-compute-intervals
branch
from
October 4, 2026 02:37
01e0847 to
d5a4411
Compare
…(RIG-2872) Each session binding is one billable compute interval. Binding writes now emit start and end rows into an append-only compute_usage_events table, in the same transaction as the binding change. ### Changes - Migration 0004_compute_usage.sql adds compute_usage_events with tenant RLS and grants, and backfills an estimated start for every binding already open. - RecordSessionBinding, DeleteSessionBinding and DeleteSessionBindingsForRunner write interval events atomically. A same-session runner change keeps its interval. - A system-role hourly sweep closes an interval whose binding vanished without an end event, marked estimated. - docs/concepts/tokens-and-billing.md describes the event log. Stop, a lost-session drop, and the Runner re-enroll reap all delete the binding, so each ends the interval. There is no pause path in the protocol today. ### Verification - pgtest race: ./internal/store, ./internal/usage, ./internal/runnerhub, ./server all ok. - sql-migration-gate (squawk + sqruff) and sqlc drift pass; golangci-lint 0 issues. Refs RIG-2872 Co-authored-by: Matt Wilkinson <matt@rigel.build>
…mp events at write time (RIG-2872) - 0004 adds usage_interval_id with a volatile default instead of UPDATE, so the set_updated_at trigger no longer overwrites the estimated start, and older servers can still insert during a rolling deploy. - The backfill runs as compass_system, as 0002 does, so FORCE RLS cannot hide rows from a non-superuser owner. - Interval events use clock_timestamp(), so an event written after a lock wait is stamped when it is written. - Hub.enroll reaps a reconnecting Runner's bindings under the system role, so every tenant's interval ends; each archive runs under the row's tenant. - Tests: conflict rollback, re-point ordering, upgrade start timestamp, cross-tenant re-enroll reap. Open decisions: RIG-4228 (joint restart leaves bindings) and RIG-4229 (cross-tenant account binding). Refs RIG-2872 Co-authored-by: Matt Wilkinson <matt@rigel.build>
… (RIG-2872) During a rolling deploy an older server inserts bindings that have no start event. A same-session rebind, a single release, or a runner sweep now first writes an estimated start (at the binding's created_at) for such a row, so the interval stays complete. ON CONFLICT keeps any real start. Tests seed a binding without events and exercise rebind then release, rebind then runner sweep, and release alone. All three fail without this change. Refs RIG-2872 Co-authored-by: Matt Wilkinson <matt@rigel.build>
…e enroll reap role (RIG-2872) - TestComputeUsageEventsStampedAfterLockWait gates a bind on the account advisory lock and asserts its events are stamped after release. It fails if the queries use now(). - TestComputeUsageLegacyBindingRepointKeepsBothIntervals re-points an event-less binding to a new session. It fails without the ensure-start call. - tenant_tx.go lists Hub.enroll's reap among system-role entrypoints; hub.go says why it is cross-tenant. - docs: inferred timestamps carry the estimated flag; drop the unqualified exact claim. Rolling-deploy coverage for old-server writes is deferred to RIG-4231. Refs RIG-2872 Co-authored-by: Matt Wilkinson <matt@rigel.build>
…-role and estimated wording (RIG-2872) - TestComputeUsageEventsStampedAfterLockWait fails if it finds fewer than the two events it pins. - tenant_tx.go lists the Runner session tenant lookup among system-role entrypoints. - docs: name which events are estimated, and say a reconnect reap records the reap time. Refs RIG-2872 Co-authored-by: Matt Wilkinson <matt@rigel.build>
After the rebase, Serve was one line over the funlen limit. startUsageSweepers starts the retention prune and the orphan-interval close together, so Serve makes one call. Co-authored-by: Matt Wilkinson <matt@rigel.build>
…ken-tenant migration (RIG-2872) Main added 0004_token_tenant.sql, so 0004_compute_usage.sql now collides and Open refuses the duplicate version. Co-authored-by: Matt Wilkinson <matt@rigel.build>
…ll (RIG-2872) Main now reaps a Runner's bindings on every enroll, so the drop test re-records its row after enroll and the reap test needs one enroll. Co-authored-by: Matt Wilkinson <matt@rigel.build>
Co-authored-by: Matt Wilkinson <matt@rigel.build>
…sue-search migration (RIG-2872) Co-authored-by: Matt Wilkinson <matt@rigel.build>
mattwilkinsonn
approved these changes
Oct 4, 2026
rigel-mintaka
force-pushed
the
compass-server/rig-2872-compute-intervals
branch
from
October 4, 2026 13:13
be6f306 to
b3a2758
Compare
mattwilkinsonn
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 2 PRs:
mainEach session binding is one billable compute interval. Binding writes now emit start and end rows into an append-only compute_usage_events table, in the same transaction as the binding change.
Changes
Stop, a lost-session drop, and the Runner re-enroll reap all delete the binding, so each ends the interval. There is no pause path in the protocol today.
Verification
Refs RIG-2872
Co-authored-by: Matt Wilkinson matt@rigel.build
Review follow-ups
Four review rounds. Fixed in additive commits: backfill start kept (no trigger-firing UPDATE), backfill runs as
compass_system, events stamped withclock_timestamp(), re-enroll reap spans tenants, estimated start for bindings an older server wrote, and tests for each.Deferred to Matt: