Repository navigation
fix(release): pin the release image ref to the manifest digest (RIG-4454) - #1653
rigel-mintaka wants to merge 2 commits into
Conversation
…454) The release body printed ghcr.io/...@<config digest>. A config blob is not a manifest, so the ref was unpullable (MANIFEST_UNKNOWN on v0.3.0). release-image now outputs the :vX.Y.Z manifest digest beside the config digest, and release-notes builds the ref from the manifest digest. The probe path hashes the raw manifest for the same value. Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
❌ This pull request could not start testing because there was a merge conflict. See more details here.
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Compass engineering docs preview: https://compass-repo-rig-4454-releas.compass-eng-docs.pages.dev Deployed from Changed pages: |
…-4454) Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
Superseded by #1775 (agent image published as an amd64+arm64 index). On main, |
Summary
The release body printed the agent image as
ghcr.io/rigelbuild/compass-agent@<config digest>. A config blob is not a manifest, so the ref could not be pulled: v0.3.0's@sha256:63210555…returnsMANIFEST_UNKNOWN, while:v0.3.0is manifestsha256:6f60bf04….release-imagenow also outputs the:vX.Y.Zmanifest digest (skopeo inspect --format '{{.Digest}}'), next to the config digest it already verifies.tools/release-notesbuildsreffrom the manifest digest and prints the config digest asconfig digest:. The flags are--image-manifest-digestand--image-config-digest, given together or not at all.Verification
bun test tools/release-notes: 26 pass. Tests updated for the new contract; a half identity throws.:v0.3.0: the probe path and the flag path both give@sha256:6f60bf04…, andskopeo inspecton that ref exits 0.actionlintonrelease.yml: the same 8 findings as main, none new.v0.3.0 is immutable, so its body stays wrong. The fix applies from v0.3.1.
Ledger-impact: none
Refs RIG-4454, RIG-1746